Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Species as another proper name in organ-anatomogram #45

Open
6 tasks
ke4 opened this issue Oct 15, 2024 · 2 comments
Open
6 tasks

Rename Species as another proper name in organ-anatomogram #45

ke4 opened this issue Oct 15, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@ke4
Copy link

ke4 commented Oct 15, 2024

The species property in the Anatomogram.js currently passed to this other components:

If we fixed this, then we should rename all along the other props and method names that goes along with this.

@ke4 ke4 added the enhancement New feature or request label Oct 15, 2024
@ke4 ke4 self-assigned this Oct 30, 2024
@ke4
Copy link
Author

ke4 commented Nov 18, 2024

Suggestion from Christina to call this field to organism_part.
There is another suggestion from @lingyun1010 to call it top_view.

We did not have enough time on the sprint planning meeting to have a final decision.
I am going to organise a separate meeting where we could properly find a solution as there might be other issues and not just a wrongly named property.

@ke4
Copy link
Author

ke4 commented Dec 11, 2024

We had a meeting related to this ticket with @sfexova @lingyun1010 and Christina.
We made the following decision:

  • @lingyun1010 revise all the documentations / SOPs regarding anatomograms till the end of this year
  • as this is not a high priority ticket, we won't touch the code for now and probably do it when we add more anatomograms

I am going to leave this ticket as open, but put back to our backlog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant