Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition group #38

Open
fadion opened this issue Dec 2, 2019 · 4 comments
Open

Transition group #38

fadion opened this issue Dec 2, 2019 · 4 comments

Comments

@fadion
Copy link

fadion commented Dec 2, 2019

Is there any way to wrap the swipe-list in a transition group? It would be really useful when doing deletes (for animating the row removal) or when dynamically inserting new rows.

@nanov
Copy link
Member

nanov commented Dec 3, 2019

Well, you could throw your own list component using SwipeOut base component, the list component just loops items and renders individual swipeouts.

@fadion
Copy link
Author

fadion commented Dec 3, 2019

That would work, although more involved. In my view, having a with-transition prop on the SwipeList component that instead of rendering a plain <div>, renders a <transition-group> would be much more usable.

Maybe that's a functionality that only a few need, so not sure how much it makes sense. Just a thought.

@nanov
Copy link
Member

nanov commented Dec 3, 2019

Maybe that's a functionality that only a few need, so not sure how much it makes sense. Just a thought.

Well it totally makes sense, and we are more than open for PRs.
As I am not the biggest expert on transition groups, I have to do some analysis on how one would define all the possibilities that would be passed to the transition-group element so we could decide on some simple, but yet feature-rich, api.

@fadion
Copy link
Author

fadion commented Dec 3, 2019

I may try and implement a version that uses transition groups in the following days. Will investigate it further and open a PR when it's ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants