diff --git a/.travis.yml b/.travis.yml index e56c2b32a83..9d027cb47a1 100644 --- a/.travis.yml +++ b/.travis.yml @@ -60,7 +60,7 @@ script: # Install tools npm install - npm run typescript-compile + npm run tsc cd Tools npm install cd .. diff --git a/Assets/JoplinIconBlack.svg b/Assets/JoplinIconBlack.svg new file mode 100644 index 00000000000..90f5c30f612 --- /dev/null +++ b/Assets/JoplinIconBlack.svg @@ -0,0 +1,31 @@ + + + + + + image/svg+xml + + + + + + + + diff --git a/BUILD.md b/BUILD.md index 7e00b45e95a..2a8dce4bb45 100644 --- a/BUILD.md +++ b/BUILD.md @@ -7,9 +7,9 @@ # TypeScript -Most of the application is written in JavaScript, however new classes and files should generally be written in [TypeScript](https://www.typescriptlang.org/). Even if you don't write TypeScript code, you will need to build the existing .ts and .tsx files. This is done from the root of the project, by running `npm run typescript-compile`. +Most of the application is written in JavaScript, however new classes and files should generally be written in [TypeScript](https://www.typescriptlang.org/). Even if you don't write TypeScript code, you will need to build the existing .ts and .tsx files. This is done from the root of the project, by running `npm run tsc`. -If you are modifying TypeScript code, the best is to have the compiler watch for changes from a terminal. To do so, run `npm run typescript-watch`. +If you are modifying TypeScript code, the best is to have the compiler watch for changes from a terminal. To do so, run `npm run tsc-watch`. All TypeScript files are generated next to the .ts or .tsx file. So for example, if there's a file "lib/MyClass.ts", there will be a generated "lib/MyClass.js" next to it. If you create a new TypeScript file, make sure you add the generated .js file to .gitignore. It is implemented that way as it requires minimal changes to integrate TypeScript in the existing JavaScript code base. @@ -37,7 +37,7 @@ npm install && cd Tools && npm install ``` rsync --delete -a ReactNativeClient/lib/ ElectronClient/app/lib/ -npm run typescript-compile +npm run tsc cd ElectronClient/app npm install yarn dist @@ -57,7 +57,7 @@ From `/ElectronClient` you can also run `run.sh` to run the app for testing. ``` xcopy /C /I /H /R /Y /S ReactNativeClient\lib ElectronClient\app\lib -npm run typescript-compile +npm run tsc cd ElectronClient\app npm install yarn dist @@ -78,7 +78,7 @@ First you need to setup React Native to build projects with native code. For thi Then: ``` -npm run typescript-compile +npm run tsc cd ReactNativeClient npm install react-native run-ios diff --git a/CliClient/build.sh b/CliClient/build.sh index e7190706c4b..929a3203cad 100755 --- a/CliClient/build.sh +++ b/CliClient/build.sh @@ -9,7 +9,7 @@ rsync -a --delete "$ROOT_DIR/../ReactNativeClient/locales/" "$BUILD_DIR/locales/ cp "$ROOT_DIR/package.json" "$BUILD_DIR" cd $ROOT_DIR/.. -npm run typescript-compile +npm run tsc cd $ROOT_DIR chmod 755 "$BUILD_DIR/main.js" \ No newline at end of file diff --git a/appveyor.yml b/appveyor.yml index 288f0e9dbfb..4922003ab2d 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -15,7 +15,7 @@ install: build_script: - ps: xcopy /C /I /H /R /Y /S ReactNativeClient\lib ElectronClient\app\lib - npm install - - npm run typescript-compile + - npm run tsc - ps: cd Tools - npm install - ps: cd ..\ElectronClient\app diff --git a/package.json b/package.json index 5b6ebac2ba6..deaf43c48b7 100644 --- a/package.json +++ b/package.json @@ -5,8 +5,8 @@ "scripts": { "linter": "./node_modules/.bin/eslint --fix --ext .js --ext .jsx --ext .ts --ext .tsx", "linter-ci": "./node_modules/.bin/eslint --ext .js --ext .jsx --ext .ts --ext .tsx", - "typescript-compile": "tsc", - "typescript-watch": "tsc --watch" + "tsc": "tsc", + "tsc-watch": "tsc --watch" }, "husky": { "hooks": {