Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitflow-helper-maven-plugin is not compatible with maven plugins that rewrite the POM file #127

Open
glimmerveen opened this issue Oct 1, 2021 · 1 comment

Comments

@glimmerveen
Copy link
Contributor

When you have a project that uses a maven plugin that rewrites the POM file (such as the flatten-maven-plugin) in combination with the gitflow-helper-maven-plugin, you'll notice that the rewritten POM file(s) are correctly uploaded to the stage repository, but not to the releases repository.

The issue is that when the build on master executes, it does download all artefacts that were build and deployed to stage, except the POM file itself. As a result, the POM file finally published into the releases repository is not the same as the one deployed to stage, but the POM file from git itself in case a plugin is activated that tries to rewrite the POM file (ie. flatten-maven-plugin).

glimmerveen added a commit to Thales-Netherlands/gitflow-helper-maven-plugin that referenced this issue Mar 9, 2022
…gitflow-helper-maven-plugin itself and the maven-deploy-plugin, or the plugins related to explicit supplied command-line goals, but also allow a project to configure additional plugins that may also execute on master/support.

This serves two cases:

1) It solves the issue e-gineering#127 (though admittedly it still would be more clean to be able to download the pom file from the release repo)
2) It can serve as a basic extension point to allow other "things" to happen on a master build, that are beyond the scope of deploying maven artifacts (ie have some antrun script run)
@glimmerveen
Copy link
Contributor Author

Submitted PR #129 that adds a feature that provides means for the described use-case to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant