From dd81aaa5291b4bdfc9a2d41690e9f0ac72e3631c Mon Sep 17 00:00:00 2001 From: mountcount Date: Fri, 29 Nov 2024 18:36:55 +0800 Subject: [PATCH] chore: fix problematic const name and some typos in comment Signed-off-by: mountcount --- protocol/app/app.go | 2 +- protocol/app/flags/flags.go | 2 +- protocol/app/process/default_market_price_decoder.go | 2 +- protocol/app/upgrades/v4.0.0/constants.go | 2 +- protocol/cmd/dydxprotocold/cmd/config.go | 2 +- protocol/x/assets/types/constants.go | 2 +- protocol/x/ratelimit/ibc_middleware.go | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-) diff --git a/protocol/app/app.go b/protocol/app/app.go index 9b16079e88..3721b239f5 100644 --- a/protocol/app/app.go +++ b/protocol/app/app.go @@ -742,7 +742,7 @@ func New( transferModule := transfer.NewAppModule(app.TransferKeeper) transferIBCModule := transfer.NewIBCModule(app.TransferKeeper) - // Wrap the x/ratelimit middlware over the IBC Transfer module + // Wrap the x/ratelimit middleware over the IBC Transfer module var transferStack ibcporttypes.IBCModule = transferIBCModule transferStack = ratelimitmodule.NewIBCMiddleware(app.RatelimitKeeper, transferStack) diff --git a/protocol/app/flags/flags.go b/protocol/app/flags/flags.go index 1a0ad084e1..4e3fdef9c7 100644 --- a/protocol/app/flags/flags.go +++ b/protocol/app/flags/flags.go @@ -165,7 +165,7 @@ func AddFlagsToCmd(cmd *cobra.Command) { // Validate checks that the flags are valid. func (f *Flags) Validate() error { - // Validtors must have cosmos grpc services enabled. + // Validators must have cosmos grpc services enabled. if !f.NonValidatingFullNode && !f.GrpcEnable { return fmt.Errorf("grpc.enable must be set to true - validating requires gRPC server") } diff --git a/protocol/app/process/default_market_price_decoder.go b/protocol/app/process/default_market_price_decoder.go index 56684f5c48..db88995d5d 100644 --- a/protocol/app/process/default_market_price_decoder.go +++ b/protocol/app/process/default_market_price_decoder.go @@ -8,7 +8,7 @@ import ( // This implementation is expected to default MarketPriceUpdates in accordance with the dydx process-proposal // logic pre vote-extensions type DefaultUpdateMarketPriceTxDecoder struct { - // pk is the expecte dependency on x/prices keeper, used for stateful validation of the returned MarketPriceUpdateTx + // pk is the expected dependency on x/prices keeper, used for stateful validation of the returned MarketPriceUpdateTx pk ProcessPricesKeeper // tx decoder used for unmarshalling the market-price-update tx diff --git a/protocol/app/upgrades/v4.0.0/constants.go b/protocol/app/upgrades/v4.0.0/constants.go index 45173de290..8b71cebe48 100644 --- a/protocol/app/upgrades/v4.0.0/constants.go +++ b/protocol/app/upgrades/v4.0.0/constants.go @@ -25,7 +25,7 @@ var Upgrade = upgrades.Upgrade{ // Add new ICA stores that are needed by ICA host types as of v8. icacontrollertypes.StoreKey, - // Add authz module to allow granting arbitrary privileges from one account to another acocunt. + // Add authz module to allow granting arbitrary privileges from one account to another account. authzkeeper.StoreKey, }, }, diff --git a/protocol/cmd/dydxprotocold/cmd/config.go b/protocol/cmd/dydxprotocold/cmd/config.go index e0e1d43c0a..cf08d27cbd 100644 --- a/protocol/cmd/dydxprotocold/cmd/config.go +++ b/protocol/cmd/dydxprotocold/cmd/config.go @@ -19,7 +19,7 @@ const ( // the chain stake token. It's also recommended that the min gas price in stake token // is roughly the same in value as 0.025 micro USDC. minGasPriceStakeToken = "25000000000adv4tnt" - // `minGasPrice` defines the default `minimum-gas-prices` attribute in validator's `app.toml` file. + // `MinGasPrice` defines the default `minimum-gas-prices` attribute in validator's `app.toml` file. MinGasPrice = minGasPriceUusdc + "," + minGasPriceStakeToken ) diff --git a/protocol/x/assets/types/constants.go b/protocol/x/assets/types/constants.go index 80d6ccb9b8..3739cad08c 100644 --- a/protocol/x/assets/types/constants.go +++ b/protocol/x/assets/types/constants.go @@ -1,7 +1,7 @@ package types const ( - // MaxAssetSymbolLength is the maximum exponent for a asset/coin unit + // MaxAssetUnitExponentAbs is the maximum exponent for a asset/coin unit // (e.g. DenomExponent, AtomicResolution) MaxAssetUnitExponentAbs = 32 ) diff --git a/protocol/x/ratelimit/ibc_middleware.go b/protocol/x/ratelimit/ibc_middleware.go index 52854ef8f7..adea0fdfe2 100644 --- a/protocol/x/ratelimit/ibc_middleware.go +++ b/protocol/x/ratelimit/ibc_middleware.go @@ -23,7 +23,7 @@ type IBCMiddleware struct { keeper keeper.Keeper } -// TODO(CORE-855): Add e2e testing for the x/ratelimit IBC Middlware +// TODO(CORE-855): Add e2e testing for the x/ratelimit IBC Middleware func NewIBCMiddleware(k keeper.Keeper, app porttypes.IBCModule) IBCMiddleware { return IBCMiddleware{ app: app,