This repository has been archived by the owner on Jan 13, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 159
/
SignedOperationProxy.sol
537 lines (462 loc) · 15.8 KB
/
SignedOperationProxy.sol
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
/*
Copyright 2019 dYdX Trading Inc.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
pragma solidity 0.5.7;
pragma experimental ABIEncoderV2;
import { SafeMath } from "openzeppelin-solidity/contracts/math/SafeMath.sol";
import { Ownable } from "openzeppelin-solidity/contracts/ownership/Ownable.sol";
import { Account } from "../../protocol/lib/Account.sol";
import { Actions } from "../../protocol/lib/Actions.sol";
import { Require } from "../../protocol/lib/Require.sol";
import { Types } from "../../protocol/lib/Types.sol";
import { OnlySolo } from "../helpers/OnlySolo.sol";
import { TypedSignature } from "../lib/TypedSignature.sol";
/**
* @title SignedOperationProxy
* @author dYdX
*
* Contract for sending operations on behalf of others
*/
contract SignedOperationProxy is
OnlySolo,
Ownable
{
using SafeMath for uint256;
// ============ Constants ============
bytes32 constant private FILE = "SignedOperationProxy";
// EIP191 header for EIP712 prefix
bytes2 constant private EIP191_HEADER = 0x1901;
// EIP712 Domain Name value
string constant private EIP712_DOMAIN_NAME = "SignedOperationProxy";
// EIP712 Domain Version value
string constant private EIP712_DOMAIN_VERSION = "1.1";
// EIP712 encodeType of EIP712Domain
bytes constant private EIP712_DOMAIN_STRING = abi.encodePacked(
"EIP712Domain(",
"string name,",
"string version,",
"uint256 chainId,",
"address verifyingContract",
")"
);
// EIP712 encodeType of Operation
bytes constant private EIP712_OPERATION_STRING = abi.encodePacked(
"Operation(",
"Action[] actions,",
"uint256 expiration,",
"uint256 salt,",
"address sender,",
"address signer",
")"
);
// EIP712 encodeType of Action
bytes constant private EIP712_ACTION_STRING = abi.encodePacked(
"Action(",
"uint8 actionType,",
"address accountOwner,",
"uint256 accountNumber,",
"AssetAmount assetAmount,",
"uint256 primaryMarketId,",
"uint256 secondaryMarketId,",
"address otherAddress,",
"address otherAccountOwner,",
"uint256 otherAccountNumber,",
"bytes data",
")"
);
// EIP712 encodeType of AssetAmount
bytes constant private EIP712_ASSET_AMOUNT_STRING = abi.encodePacked(
"AssetAmount(",
"bool sign,",
"uint8 denomination,",
"uint8 ref,",
"uint256 value",
")"
);
// EIP712 typeHash of EIP712Domain
/* solium-disable-next-line indentation */
bytes32 constant private EIP712_DOMAIN_SEPARATOR_SCHEMA_HASH = keccak256(abi.encodePacked(
EIP712_DOMAIN_STRING
));
// EIP712 typeHash of Operation
/* solium-disable-next-line indentation */
bytes32 constant private EIP712_OPERATION_HASH = keccak256(abi.encodePacked(
EIP712_OPERATION_STRING,
EIP712_ACTION_STRING,
EIP712_ASSET_AMOUNT_STRING
));
// EIP712 typeHash of Action
/* solium-disable-next-line indentation */
bytes32 constant private EIP712_ACTION_HASH = keccak256(abi.encodePacked(
EIP712_ACTION_STRING,
EIP712_ASSET_AMOUNT_STRING
));
// EIP712 typeHash of AssetAmount
/* solium-disable-next-line indentation */
bytes32 constant private EIP712_ASSET_AMOUNT_HASH = keccak256(abi.encodePacked(
EIP712_ASSET_AMOUNT_STRING
));
// ============ Structs ============
struct OperationHeader {
uint256 expiration;
uint256 salt;
address sender;
address signer;
}
struct Authorization {
uint256 numActions;
OperationHeader header;
bytes signature;
}
// ============ Events ============
event ContractStatusSet(
bool operational
);
event LogOperationExecuted(
bytes32 indexed operationHash,
address indexed signer,
address indexed sender
);
event LogOperationCanceled(
bytes32 indexed operationHash,
address indexed canceler
);
// ============ Immutable Storage ============
// Hash of the EIP712 Domain Separator data
bytes32 public EIP712_DOMAIN_HASH;
// ============ Mutable Storage ============
// true if this contract can process operationss
bool public g_isOperational;
// operation hash => was executed (or canceled)
mapping (bytes32 => bool) public g_invalidated;
// ============ Constructor ============
constructor (
address soloMargin,
uint256 chainId
)
public
OnlySolo(soloMargin)
{
g_isOperational = true;
/* solium-disable-next-line indentation */
EIP712_DOMAIN_HASH = keccak256(abi.encode(
EIP712_DOMAIN_SEPARATOR_SCHEMA_HASH,
keccak256(bytes(EIP712_DOMAIN_NAME)),
keccak256(bytes(EIP712_DOMAIN_VERSION)),
chainId,
address(this)
));
}
// ============ Admin Functions ============
/**
* The owner can shut down the exchange.
*/
function shutDown()
external
onlyOwner
{
g_isOperational = false;
emit ContractStatusSet(false);
}
/**
* The owner can start back up the exchange.
*/
function startUp()
external
onlyOwner
{
g_isOperational = true;
emit ContractStatusSet(true);
}
// ============ Public Functions ============
/**
* Allows a signer to permanently cancel an operation on-chain.
*
* @param accounts The accounts involved in the operation
* @param actions The actions involved in the operation
* @param auth The unsigned authorization of the operation
*/
function cancel(
Account.Info[] memory accounts,
Actions.ActionArgs[] memory actions,
Authorization memory auth
)
public
{
bytes32 operationHash = getOperationHash(
accounts,
actions,
auth,
0
);
Require.that(
auth.header.signer == msg.sender,
FILE,
"Canceler must be signer"
);
g_invalidated[operationHash] = true;
emit LogOperationCanceled(operationHash, msg.sender);
}
/**
* Submits an operation to SoloMargin. Actions for accounts that the msg.sender does not control
* must be authorized by a signed message. Each authorization can apply to multiple actions at
* once which must occur in-order next to each other. An empty authorization must be supplied
* explicitly for each group of actions that do not require a signed message.
*
* @param accounts The accounts to forward to SoloMargin.operate()
* @param actions The actions to forward to SoloMargin.operate()
* @param auths The signed authorizations for each group of actions
* (or unsigned if msg.sender is already authorized)
*/
function operate(
Account.Info[] memory accounts,
Actions.ActionArgs[] memory actions,
Authorization[] memory auths
)
public
{
Require.that(
g_isOperational,
FILE,
"Contract is not operational"
);
// cache the index of the first action for this auth
uint256 actionStartIdx = 0;
// loop over all auths
for (uint256 authIdx = 0; authIdx < auths.length; authIdx++) {
Authorization memory auth = auths[authIdx];
// require that the message is not expired
Require.that(
auth.header.expiration == 0 || auth.header.expiration >= block.timestamp,
FILE,
"Signed operation is expired",
authIdx
);
// require that the sender matches the authorization
Require.that(
auth.header.sender == address(0) || auth.header.sender == msg.sender,
FILE,
"Operation sender mismatch",
authIdx
);
// consider the signer to be msg.sender unless there is a signature
address signer = msg.sender;
// if there is a signature, then validate it
if (auth.signature.length != 0) {
// get the hash of the operation
bytes32 operationHash = getOperationHash(
accounts,
actions,
auth,
actionStartIdx
);
// require that this message is still valid
Require.that(
!g_invalidated[operationHash],
FILE,
"Hash already used or canceled",
operationHash
);
// get the signer
signer = TypedSignature.recover(operationHash, auth.signature);
// require that this signer matches the authorization
Require.that(
auth.header.signer == signer,
FILE,
"Invalid signature"
);
// consider this operationHash to be used (and therefore no longer valid)
g_invalidated[operationHash] = true;
emit LogOperationExecuted(operationHash, signer, msg.sender);
}
// cache the index of the first action after this auth
uint256 actionEndIdx = actionStartIdx.add(auth.numActions);
// loop over all actions for which this auth applies
for (uint256 actionIdx = actionStartIdx; actionIdx < actionEndIdx; actionIdx++) {
// validate primary account
Actions.ActionArgs memory action = actions[actionIdx];
validateAccountOwner(accounts[action.accountId].owner, signer);
// validate second account in the case of a transfer
if (action.actionType == Actions.ActionType.Transfer) {
validateAccountOwner(accounts[action.otherAccountId].owner, signer);
}
}
// update actionStartIdx
actionStartIdx = actionEndIdx;
}
// require that all actions are signed or from msg.sender
Require.that(
actionStartIdx == actions.length,
FILE,
"Not all actions are signed"
);
// send the operation
SOLO_MARGIN.operate(accounts, actions);
}
// ============ Getters ============
/**
* Returns a bool for each operation. True if the operation is invalid (from being canceled or
* previously executed).
*/
function getOperationsAreInvalid(
bytes32[] memory operationHashes
)
public
view
returns(bool[] memory)
{
uint256 numOperations = operationHashes.length;
bool[] memory output = new bool[](numOperations);
for (uint256 i = 0; i < numOperations; i++) {
output[i] = g_invalidated[operationHashes[i]];
}
return output;
}
// ============ Private Helper Functions ============
/**
* Validates that either the signer or the msg.sender are the accountOwner (or that either are
* localOperators of the accountOwner).
*/
function validateAccountOwner(
address accountOwner,
address signer
)
private
view
{
bool valid =
msg.sender == accountOwner
|| signer == accountOwner
|| SOLO_MARGIN.getIsLocalOperator(accountOwner, msg.sender)
|| SOLO_MARGIN.getIsLocalOperator(accountOwner, signer);
Require.that(
valid,
FILE,
"Signer not authorized",
signer
);
}
/**
* Returns the EIP712 hash of an Operation message.
*/
function getOperationHash(
Account.Info[] memory accounts,
Actions.ActionArgs[] memory actions,
Authorization memory auth,
uint256 startIdx
)
private
view
returns (bytes32)
{
// get the bytes32 hash of each action, then packed together
bytes32 actionsEncoding = getActionsEncoding(
accounts,
actions,
auth,
startIdx
);
// compute the EIP712 hashStruct of an Operation struct
/* solium-disable-next-line indentation */
bytes32 structHash = keccak256(abi.encode(
EIP712_OPERATION_HASH,
actionsEncoding,
auth.header
));
// compute eip712 compliant hash
/* solium-disable-next-line indentation */
return keccak256(abi.encodePacked(
EIP191_HEADER,
EIP712_DOMAIN_HASH,
structHash
));
}
/**
* Returns the EIP712 encodeData of an Action struct array.
*/
function getActionsEncoding(
Account.Info[] memory accounts,
Actions.ActionArgs[] memory actions,
Authorization memory auth,
uint256 startIdx
)
private
pure
returns (bytes32)
{
// store hash of each action
bytes32[] memory actionsBytes = new bytes32[](auth.numActions);
// for each action that corresponds to the auth
for (uint256 i = 0; i < auth.numActions; i++) {
Actions.ActionArgs memory action = actions[startIdx + i];
// if action type has no second account, assume null account
Account.Info memory otherAccount =
(Actions.getAccountLayout(action.actionType) == Actions.AccountLayout.OnePrimary)
? Account.Info({ owner: address(0), number: 0 })
: accounts[action.otherAccountId];
// compute the individual hash for the action
/* solium-disable-next-line indentation */
actionsBytes[i] = getActionHash(
action,
accounts[action.accountId],
otherAccount
);
}
return keccak256(abi.encodePacked(actionsBytes));
}
/**
* Returns the EIP712 hashStruct of an Action struct.
*/
function getActionHash(
Actions.ActionArgs memory action,
Account.Info memory primaryAccount,
Account.Info memory secondaryAccount
)
private
pure
returns (bytes32)
{
/* solium-disable-next-line indentation */
return keccak256(abi.encode(
EIP712_ACTION_HASH,
action.actionType,
primaryAccount.owner,
primaryAccount.number,
getAssetAmountHash(action.amount),
action.primaryMarketId,
action.secondaryMarketId,
action.otherAddress,
secondaryAccount.owner,
secondaryAccount.number,
keccak256(action.data)
));
}
/**
* Returns the EIP712 hashStruct of an AssetAmount struct.
*/
function getAssetAmountHash(
Types.AssetAmount memory amount
)
private
pure
returns (bytes32)
{
/* solium-disable-next-line indentation */
return keccak256(abi.encode(
EIP712_ASSET_AMOUNT_HASH,
amount.sign,
amount.denomination,
amount.ref,
amount.value
));
}
}