Skip to content
This repository has been archived by the owner on Mar 18, 2024. It is now read-only.

Unwanted behavior - Git Identity #1310

Open
sandinocoelho opened this issue May 16, 2023 · 1 comment
Open

Unwanted behavior - Git Identity #1310

sandinocoelho opened this issue May 16, 2023 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@sandinocoelho
Copy link

Describe the bug
When calling sfpowerscripts:orchestrator:publish without set any of the environment variables SFPOWERSCRIPTS_GIT_USERNAME and SFPOWERSCRIPTS_GIT_EMAIL, causes to override the global/local git config on my local project.

To Reproduce
Steps to reproduce the behavior:
Simply call the sfpowerscripts:orchestrator:publish method or other that calls the GitIdentity() method.

Expected behavior
When the global or local Git Config was set, I thing that call the method GitIdentity is useless.

Screenshots
image
image

Platform Details (please complete the following information):

  • OS: macOS
  • Version [e.g. CLI Version eg: 1.6.6]: 13.3.1 22E261 arm64
  • Salesforce CLI(sfdx cli) Version: sfdx-cli/7.197.8 darwin-x64 node-v14.19.2
  • CI Platform: N/A

Additional context
Maybe validate if the global/local user configs exist and bypass the setUsernameAndEmail in this case.

@github-actions github-actions bot added the analysis To be decided on how to solution/fix label May 16, 2023
@azlam-abdulsalam azlam-abdulsalam self-assigned this Jun 29, 2023
@azlam-abdulsalam azlam-abdulsalam added bug Something isn't working and removed analysis To be decided on how to solution/fix labels Jun 29, 2023
@azlam-abdulsalam azlam-abdulsalam added this to the August 23 milestone Jun 29, 2023
@azlam-abdulsalam
Copy link
Contributor

Thanks @sandinocoelho , will address this in a future release

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants