A bit confused by readme

[Conorc1000]

In this section we are told to add some code to the nightwatch.conf.js

Download Selenium (Web Driver) Standalone Server (Script)

Once you've downloaded the the selenium-download node module, put the following code at the bottom of your nightwatch.conf.js file:

require('selenium-download').ensure('./bin', function(error) {  
   if (error) {
     return console.log(error);
   } else {
     console.log('✔ Selenium & Chromedriver downloaded to:', './bin');
   }
});
We run include this script in our nightwatch.conf.js which checks for the existence of selenium.jar before trying to run our tests. You will create your nightwatch.conf.js file in the next step.

But I dont believe the code is require. It appear to already be in the file.

[nelsonic]

@Conorc1000, you're right, it is already in the sample nightwatch.conf.js

learn-nightwatch/nightwatch.conf.js

Lines 119 to 131 in 84cca8d

	/**
	* selenium-download does exactly what it's name suggests;
	* downloads (or updates) the version of Selenium (& chromedriver)
	* on your localhost where it will be used by Nightwatch.
	*/
	require('fs').stat(BINPATH + 'selenium.jar', function (err, stat) { // got it?
	if (err || !stat || stat.size < 1) {
	require('selenium-download').ensure(BINPATH, function(error) {
	if (error) throw new Error(error); // no point continuing so exit!
	console.log('✔ Selenium & Chromedriver downloaded to:', BINPATH);
	});
	}
	});

But if someone was setting up their own project independently of this tutorial, we recommend they add those lines so that selenium-download .ensure will be run and we are sure that Selenium and Chromedriver are installed.

If you can improve the wording, please go for it! 👍

[nelsonic]

@Conorc1000 are you still confused.com by the readme...?

[AlainPilon]

I think removing the code while keeping the section 5 is even more confusing ;-)

[nelsonic]

@AlainPilon given that you are our "fresh pair of eyes" on this, can you please help us improve it? (e.g. with a Pull Request... thanks!)

[AlainPilon]

I really want to use Nightwatch to do our testing so, yes, I will submit a few PR and newb questions along the way.