Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLFeatureSelection目录下importance_selection.py文件中_ScoreUpdate函数纠正 #17

Open
milkboylyf opened this issue Sep 11, 2019 · 0 comments

Comments

@milkboylyf
Copy link

该函数在什么条件下都会返回一个True。正确写法是不是应该如下:
def _ScoreUpdate(self):
if self._direction == 'ascend':
start = -np.inf
else:
start = np.inf
if self._score == start:
return True
elif self._evaluate(self._score, self.bestscore):
self.bestscore, self._bestfeature = self._score, self._TemplUsedFeatures[:]
return True
return False

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant