Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify documentation for inject.reference and registry keys #61

Open
bcmills opened this issue Oct 10, 2024 · 0 comments
Open

Clarify documentation for inject.reference and registry keys #61

bcmills opened this issue Oct 10, 2024 · 0 comments
Labels

Comments

@bcmills
Copy link
Contributor

bcmills commented Oct 10, 2024

Currently the documentation for inject.reference is:

Return a reference to another registry key.

Unfortunately, at that point we haven't really defined what a “registry key” is: https://github.com/duolingo/minject/blob/master/docs/dependency_injection.md#storing-instantiated-classes suggests that it is a class, but generally the things we bind with @bind are instances rather than class objects.

It would be nice to clarify exactly what kind of thing the reference function returns and how that interacts with the other minject functions.

@bcmills bcmills added the docs label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

1 participant