Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support generic action/deep link formats #1077

Open
kaerez opened this issue Jul 16, 2024 · 3 comments
Open

Support generic action/deep link formats #1077

kaerez opened this issue Jul 16, 2024 · 3 comments

Comments

@kaerez
Copy link

kaerez commented Jul 16, 2024

Support the regex below, which supports other valid links such as:
sms:+12125551212
call:2125551212
whatsapp://send
com.acme.a1t-3://license?set=1f6R@!a

Applicable regex: ([\S]+:[\S]+)

Copy link

linear bot commented Jul 16, 2024

@steven-tey
Copy link
Collaborator

We do have the isSupportedDeepLinkProtocol check which supports most of the examples here, but we're wary of opening it up to a generic regex in case of abuse. Any thoughts/advice here?

@kaerez
Copy link
Author

kaerez commented Jul 21, 2024

Deeplinks are officially supported in RFC's and by Google and Apple. Any HTML can have a meta redirect, shadow (reporting) link, direct href link, etc...
I think, at least for custom domains, this should be permitted. This could also be an opportunity to possibly support adding a permissive and/or restrictive regex to the ui for admins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants