Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend Routes #4

Open
5 tasks done
gorterd opened this issue Jan 13, 2021 · 0 comments
Open
5 tasks done

Backend Routes #4

gorterd opened this issue Jan 13, 2021 · 0 comments

Comments

@gorterd
Copy link
Collaborator

gorterd commented Jan 13, 2021

To Revise:

  • I wouldn't include a users index route. Reason being, the news feed is essentially a list of checkins sorted by the created_at date of the checkin itself. While your checkins index should probably return user data with it, I don't think you need a users index.
  • Which route returns all the checkins for a particular drink / brewery? Would make sense to include with the drink / brewery show pages (if so, I'd mention that explicitly), but could also be nested checkin index routes (example: /api/drinks/1/checkins could retrieve all checkins associated with a drink);
  • ^ Same goes for getting all the drinks associated with a particular brewery, all the checkins made by a user, and all the drinks reviewed by a user (if you include that feature in your user profile: see last MVP note)
  • These probably don't warrant their own routes, but I'd also be explicit about which routes return data for the comments / toasts associated with each checkin
  • You'll need a route for editing a comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant