Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCA configuration #22

Open
kai-ho opened this issue Dec 17, 2017 · 2 comments
Open

SCA configuration #22

kai-ho opened this issue Dec 17, 2017 · 2 comments
Assignees
@RGHenderson @kai-ho

Comments

@kai-ho
Copy link
Member

kai-ho commented Dec 17, 2017

Configuration of Checkstyle, PMD, FindBugs is currently written to be compatible with Maven reporting targets and Jenkins plug-ins of that tools. This has to be adjusted to work with "plain" Maven build, i.e. violations should be logged to the console and fail the build. SCA tools will also need to be executed in the (Maven/Travis) build which requires existing SCA markers to be cleaned up.
@kai-ho kai-ho self-assigned this Dec 17, 2017
@kai-ho
Copy link
Member Author

kai-ho commented Dec 18, 2017

@rmitin: This issue is fixed with kai-ho@faa30a5, however the build fails on that as we have some SCA violations. Let's fix them and I will create a pull request then...

rmitin referenced this issue in kai-ho/dsl-devkit Dec 18, 2017
@kai-ho
dsldevkit#21: Adjust SCA configuration
faa30a5 
- Log Checkstyle, PMD, and Findbugs markers to Maven console
- Execute SCA analyses in Maven/Travis build and fail on any violation

Issue: dsldevkit#21
Change-Id: If274aad173d857eea1b8386f6ee4a8d17d2ee6ed
kai-ho added a commit to kai-ho/dsl-devkit that referenced this issue Dec 20, 2017
@kai-ho
dsldevkit#22: Adjust SCA configuration
01827b8 
- Log Checkstyle, PMD, and Findbugs markers to Maven console
- Execute SCA analyses in Maven/Travis build and fail on any violation

Issue: dsldevkit#22
Change-Id: If274aad173d857eea1b8386f6ee4a8d17d2ee6ed
@kai-ho
Copy link
Member Author

kai-ho commented Dec 20, 2017

This is basically fixed with the integration of pull request #25. However, PMD and Findbugs are not active yet (see 3cc5e84).

RGHenderson pushed a commit to RGHenderson/dsl-devkit that referenced this issue Dec 20, 2017
dsldevkit#22: SCA configuration
49676a8 
 - Phase 1 of "Fix potential PMD violations"

Issue: dsldevkit#22
RGHenderson pushed a commit to RGHenderson/dsl-devkit that referenced this issue Dec 20, 2017
dsldevkit#22: SCA configuration - workspace and maven config
a4776b7 
 - Add settings to .project of all project where SCA config was not
linked
 - Add test settings and link where appropriate (tests)
 - Add test settings to pom.xml of tests for maven builds - override
standard pmd/checkstyle config

Issue: dsldevkit#22
RGHenderson pushed a commit to RGHenderson/dsl-devkit that referenced this issue Dec 20, 2017
dsldevkit#22: SCA configuration - derived resource exclusion
4830af5 
 - Exclude derived src-model and xtend-gen folders from SCA

Issue: dsldevkit#22
RGHenderson pushed a commit to RGHenderson/dsl-devkit that referenced this issue Dec 20, 2017
dsldevkit#22: SCA configuration - cleanup trivial PMD
64ba65a 
 - Cleanup some of the more trivial PMD warnings and suppress where
appropriate

Issue: dsldevkit#22
RGHenderson pushed a commit to RGHenderson/dsl-devkit that referenced this issue Dec 20, 2017
- Cleanup some of the more trivial PMD warnings and suppress where
29c35e6 
appropriate

Issue: dsldevkit#22
RGHenderson pushed a commit to RGHenderson/dsl-devkit that referenced this issue Dec 20, 2017
dsldevkit#22: SCA configuration - final PMD cleanup
392c65b 
 - Cleanup less trivial PMD warnings

Issue: dsldevkit#22
RGHenderson pushed a commit to RGHenderson/dsl-devkit that referenced this issue Dec 20, 2017
dsldevkit#22: SCA configuration - missed cleanups
06c69f8 
 - Catch some final cleanups of PMD

Issue: dsldevkit#22
RGHenderson pushed a commit to RGHenderson/dsl-devkit that referenced this issue Dec 20, 2017
dsldevkit#22: SCA configuration - missed cleanups
a91fcb3 
 - Catch some final cleanups of PMD - phase 2

Issue: dsldevkit#22
RGHenderson pushed a commit to RGHenderson/dsl-devkit that referenced this issue Dec 21, 2017
dsldevkit#22: SCA configuration - unify configuration
c134074 
 - Remove explicit test configuration for pmd and checkstyle
 - Cleanup new PMD in tests
 - Add checkstyle suppressions for Test and TestUtil classes
 - Disable CPD from parent to not check generated source

Issue: dsldevkit#22
RGHenderson pushed a commit to RGHenderson/dsl-devkit that referenced this issue Dec 21, 2017
dsldevkit#22: SCA configuration - fixes
fa00851 
 - Fix accidental use of StringBuilder(int) constructor

Issue: dsldevkit#22
RGHenderson pushed a commit to RGHenderson/dsl-devkit that referenced this issue Dec 21, 2017
dsldevkit#22: SCA configuration - enable cpd in child pom
f3c052e 
 - Enable CPD threshold of 100 in child poms

Issue: dsldevkit#22
RGHenderson pushed a commit to RGHenderson/dsl-devkit that referenced this issue Dec 21, 2017
dsldevkit#22: SCA configuration - suppress Test checkstyle
7fd810d 
 - Disable some checkstyle violations in *Test*.java sources and
*Bug*.java sources

Issue: dsldevkit#22
RGHenderson pushed a commit to RGHenderson/dsl-devkit that referenced this issue Dec 21, 2017
dsldevkit#22: SCA configuration
8ae4984 
 - Phase 1 of "Fix potential PMD violations"

Issue: dsldevkit#22
RGHenderson pushed a commit to RGHenderson/dsl-devkit that referenced this issue Dec 21, 2017
dsldevkit#22: SCA configuration - workspace and maven config
1fd9a53 
 - Add settings to .project of all project where SCA config was not
linked
 - Add test settings and link where appropriate (tests)
 - Add test settings to pom.xml of tests for maven builds - override
standard pmd/checkstyle config

Issue: dsldevkit#22
RGHenderson pushed a commit to RGHenderson/dsl-devkit that referenced this issue Dec 21, 2017
dsldevkit#22: SCA configuration - derived resource exclusion
a96bdcd 
 - Exclude derived src-model and xtend-gen folders from SCA

Issue: dsldevkit#22
RGHenderson pushed a commit to RGHenderson/dsl-devkit that referenced this issue Dec 21, 2017
- Cleanup some of the more trivial PMD warnings and suppress where
6abd547 
appropriate

Issue: dsldevkit#22
RGHenderson pushed a commit to RGHenderson/dsl-devkit that referenced this issue Dec 21, 2017
dsldevkit#22: SCA configuration - final PMD cleanup
314500b 
 - Cleanup less trivial PMD warnings

Issue: dsldevkit#22
RGHenderson pushed a commit to RGHenderson/dsl-devkit that referenced this issue Dec 21, 2017
dsldevkit#22: SCA configuration - missed cleanups
abaf739 
 - Catch some final cleanups of PMD

Issue: dsldevkit#22
RGHenderson pushed a commit to RGHenderson/dsl-devkit that referenced this issue Dec 21, 2017
dsldevkit#22: SCA configuration - missed cleanups
04fbb98 
 - Catch some final cleanups of PMD - phase 2

Issue: dsldevkit#22
RGHenderson pushed a commit to RGHenderson/dsl-devkit that referenced this issue Dec 21, 2017
dsldevkit#22: SCA configuration - unify configuration
8899895 
 - Remove explicit test configuration for pmd and checkstyle
 - Cleanup new PMD in tests
 - Add checkstyle suppressions for Test and TestUtil classes
 - Disable CPD from parent to not check generated source

Issue: dsldevkit#22
RGHenderson pushed a commit to RGHenderson/dsl-devkit that referenced this issue Dec 21, 2017
dsldevkit#22: SCA configuration - fixes
78a1cac 
 - Fix accidental use of StringBuilder(int) constructor

Issue: dsldevkit#22
RGHenderson pushed a commit to RGHenderson/dsl-devkit that referenced this issue Dec 21, 2017
dsldevkit#22: SCA configuration - suppress Test checkstyle
6103beb 
 - Disable some checkstyle violations in *Test*.java sources and
*Bug*.java sources

Issue: dsldevkit#22
RGHenderson pushed a commit to RGHenderson/dsl-devkit that referenced this issue Dec 21, 2017
dsldevkit#22: SCA configuration
418f1ca 
 - Cleanup tabs <-> spaces
 - Address NPE possibility in CheckExtensionHelperManager

Issue: dsldevkit#22
@RGHenderson RGHenderson self-assigned this Dec 21, 2017
RGHenderson pushed a commit to RGHenderson/dsl-devkit that referenced this issue Dec 21, 2017
dsldevkit#22: SCA configuration
ea9aeb8 
 - Fix final PMD warning in Serializer Context

Issue: dsldevkit#22
RGHenderson pushed a commit to RGHenderson/dsl-devkit that referenced this issue Dec 22, 2017
dsldevkit#22: SCA configuration
694a54a 
 - Remove findbugs test project preferences

Issue: dsldevkit#22
RGHenderson added a commit that referenced this issue Dec 22, 2017
@RGHenderson
Merge pull request #27 from splittie96/master
f1d9ea7 
Issue #22 - SCA configuration and PMD cleanup
ava-fred pushed a commit that referenced this issue Mar 16, 2021
@rubenporras
Merge pull request #22 from dsldevkit/master
201682c 
rebase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RGHenderson RGHenderson

@kai-ho kai-ho

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RGHenderson @kai-ho