Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UpdateServicesServer] Add IGNORE option to UpstreamServerName #56

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[UpdateServicesServer] Add IGNORE option to UpstreamServerName #56

wants to merge 2 commits into from

Conversation

CraigTolley
Copy link

@CraigTolley CraigTolley commented May 26, 2020 •
edited by johlju
Loading

Pull Request (PR) description

Allows the UpstreamServerName value to be set to IGNORE, allowing the check to be skipped where the upstream server should neither be Microsoft Update, nor managed by DSC. Example use is with SCCM Software Update Point.

This Pull Request (PR) fixes the following issues

Fixes #55

Task list

  • Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

@gaelcolas
Copy link
Member

Thanks for the contribution!
I'm not very familiar with how it works with SCCM, can you explain the nuance between using 'ignore' or just not setting it in the resource property?

@gaelcolas
Copy link
Member

Also I probably won't have much time until this weekend, so please come and chase me on slack (PowerShell slack, #dsc channel).

@CraigTolley
Copy link
Author

SCCM expects the basic WSUS components to be installed, but once that is in place it will manage the upstream server based on the SCCM hierarchy. This means that the upstream server can change from the DSC configuration, and this is absolutely fine.

This means that it is difficult to specify the correct upstream server in the DSC configuration. By adding an option for IGNORE, we can effectively say 'yep, this value can change and that is OK'.

@NicolasBn
Copy link
Member

Hello @CraigTolley,
Sorry for the long time.
Can you rebase your changes and resolv conflicts ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brajjan brajjan brajjan approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[UpdateServicesServer] Upstream Server triggers reconfigure when not specified
4 participants
@CraigTolley @gaelcolas @NicolasBn @brajjan