Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to the latest TZ Shapefiles #9

Open
mvrhov opened this issue Jun 8, 2016 · 6 comments
Open

Update to the latest TZ Shapefiles #9

mvrhov opened this issue Jun 8, 2016 · 6 comments

Comments

@mvrhov
Copy link

mvrhov commented Jun 8, 2016

Unfortunately, the timezones are changed in various countries a couple a times a year. So the TZ database gets updated. It would be nice to update the data to latest TZ shapefiles at least twice a year.

@sankarsana
Copy link

I join the request! Please fix it.

@stephent
Copy link

It appears that regularly updated shapefiles are available from here: https://github.com/evansiroky/timezone-boundary-builder. Could they function as an updated source for this project?

@darpandhamija
Copy link

I have a fix available for it. I've picked the latest shapefiles and updated this library with the latest timezone. @drtimcooper How can I contribute ?

@drtimcooper
Copy link
Owner

@darpandhamija Have you executed the code to create the target java/csharp/objectivec code? Does the new version of the files work? You should test it with at least one of the supported languages. If it works then: are you familiar with git? Can you create a git pull request? I'll merge it if you're confident that it works.

@darpandhamija
Copy link

Yes @drtimcooper, I had to update the convertingShapeFilesToJson,

  • I've upgraded to latest ShapeFile lib version.
  • I had to update toJson.c for creating polygons from new shapefiles
  • update paths on TimeZoneMapperConverter.java to more generic ones to finally generate .java and .swift files.
  • I've added some more test cases for the file and compared the result with other libraries and Google Timezone API response and it has improved results as compared to before. Something that'll resolve another issue : False TimeZone for 50.66665/-0.95290923 #19

I am familiar with git and create PullRequest for you to merge.

@drtimcooper
Copy link
Owner

Hi @darpandhamija : Thanks for your hard work! But I can't see your Pull Request. I can only see one PR and it's not yours. Can you try again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants