You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In some situations, calling Editor::setValue will have no effect.
Ran across this issue on our site with our "Start Over" feature. Repro was starting a level, switching from block mode to text mode, typing a few lines, and then clicking "Start Over."
Root cause seems to be an outdated @lastAceSeenValue. This check is not checking the current value of the editor, because it's only updated when getAceValue is called, which does not include when typing into the editor. Thus the function can mistakenly think no change is needed, when in fact it is.
Either this check should query the actual current value of the ace editor, or it might not be necessary at all - hopefully Ace swallows redundant set calls internally.
The text was updated successfully, but these errors were encountered:
...for a Droplet bug,
See droplet-editor/droplet#137
Calling getValue() updates the cached ace editor value, which can be out-of-date in droplet and cause an incorrect early-out.
Could remove this line once that bug is fixed and Droplet is updated.
In some situations, calling Editor::setValue will have no effect.
Ran across this issue on our site with our "Start Over" feature. Repro was starting a level, switching from block mode to text mode, typing a few lines, and then clicking "Start Over."
Root cause seems to be an outdated
@lastAceSeenValue
. This check is not checking the current value of the editor, because it's only updated whengetAceValue
is called, which does not include when typing into the editor. Thus the function can mistakenly think no change is needed, when in fact it is.Either this check should query the actual current value of the ace editor, or it might not be necessary at all - hopefully Ace swallows redundant set calls internally.
The text was updated successfully, but these errors were encountered: