No progress updates when executing a batch upload with small files

[gertjanvg]

I have been working on an application that uploads a bunch of photos to Dropbox. All of the photos are pretty small and I used the batch upload method available in Dropbox to upload all of them. Everything worked, up until the point I wanted to track the progress of the upload process. I passed a BatchUploadResponseBlock as parameter for FilesRoutes.batchUploadFiles, but no progress is being reported.

Diving into the source code revealed the following issue: there are two different types of file uploading: small files and large files. Since all of my files were small all of them were passed to the startUploadSmallFile method. It turned out that startUploadSmallFile does not actually ever call self.executeProgressHandler, which results in no progress being reported at all.

I have not yet tested whether this lack of reporting results in incorrect progress reporting when mixing small and large files, but my guess is it does. This obviously is an issue because one would expect progress from an upload task, especially a batched task.

For now I have put in place a quick bugfix, but a more elegant solution should be found. I will most likely submit a pull request later on with a better solution.

[greg-db]

Thanks for the report! We'll look into it.

[dor4emon]

Hi @gertjanvg , may I ask which batch upload method you are using? I can't find it
Thanks

[greg-db]

@dor4emon They are referring to the batchUploadFiles method. There's an example in the test class. Apologies this isn't properly documented! I'll ask the team to add some documentation.

[angelFrog]

This issue still exists.

As @gertjanvg says, the fix is quick and easy, just adding executeProgressHandler etc. to the end of startUploadSmallFile to match the end of startUploadLargeFile.

[greg-db]

@angelFrog Thanks for the note! I'll bring this up with the team.

[pumPkin555]

I have tested as @angelFrog said and @gertjanvg guessed, but nothing happens. I still do not have progress. Can somebody help how to get progress?

[greg-db]

@pumPkin555 This issue is still open with the team, but it hasn't been addressed yet. I'll follow up here if/when I have an update on it.

[pumPkin555]

Thank you @greg-db! I look forward to your update.

[strong84]

Does it support batchUploadData instead of files?

[greg-db]

@strong84 No, the SDK doesn't offer a version of this method that takes Data objects instead of files, but I'll pass this along as a feature request. I can't promise if or when that might be implemented though.