Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Improvements #73

Open
wangerekaharun opened this issue Jan 16, 2020 · 5 comments
Open

Code Improvements #73

wangerekaharun opened this issue Jan 16, 2020 · 5 comments
Assignees
@michaelbukachi @wangerekaharun

Comments

@wangerekaharun
Copy link
Collaborator

After reading this Pokedex Review. I felt there are a couple of points on lifecycle and architecture components that we would borrow from them.
@wangerekaharun wangerekaharun self-assigned this Jan 16, 2020
@wangerekaharun wangerekaharun mentioned this issue Jan 16, 2020
Open
@michaelbukachi
Copy link
Collaborator

I can't believe I never knew about viewLifecycleOwner till today. We should definitely try to improve the code where we can.

@michaelbukachi
Copy link
Collaborator

But we should also take note of that some of the problems highlighted are already solved using kotlin goodness and DI.

@wangerekaharun
Copy link
Collaborator Author

I can't believe I never knew about viewLifecycleOwner till today. We should definitely try to improve the code where we can.

Also knew with that article. Yes am working on it.

wangerekaharun added a commit that referenced this issue Jan 16, 2020
@wangerekaharun
fix:Use viewLifeCycleOwner for livedata observation. This addresses #73
0c39597
wangerekaharun added a commit that referenced this issue Jan 16, 2020
@wangerekaharun
Fix: Replaced OnCreateView with Fragment LayoutId constructor in all …
49f0941 
…Fragments. This Addresses #73
wangerekaharun added a commit that referenced this issue Jan 16, 2020
@wangerekaharun
Fix: Added labels in all lambdas instead of using the implicit it. Th…
5f8c4ad 
…is addresses #73
wangerekaharun added a commit that referenced this issue Jan 17, 2020
@wangerekaharun
Fix: moved remote config logi to repo for travel fragment. Fixed erro…
88f59e2 
…r for reomote config when there is no internet. This addresses #73 and #72
wangerekaharun added a commit that referenced this issue Jan 24, 2020
@wangerekaharun
Fix: Improved MapFragment Code. This addresses #73
f80c48c
@wangerekaharun
Copy link
Collaborator Author

@michaelbukachi Done with all the suggestions from the article and code improvements. You can also have a look at areas where you can also improve.

@michaelbukachi
Copy link
Collaborator

Awesome. Let me take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelbukachi michaelbukachi

@wangerekaharun wangerekaharun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michaelbukachi @wangerekaharun