Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate and better handle NoDataInBounds #23

Open
2 tasks
klwetstone opened this issue Aug 10, 2023 · 2 comments
Open
2 tasks

Investigate and better handle NoDataInBounds #23

klwetstone opened this issue Aug 10, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@klwetstone
Copy link
Collaborator

klwetstone commented Aug 10, 2023

Some sample / item combinations raise a rioxarray.exceptions.NoDataInBounds error. In some cases, this happens even when the bounding box used is within the bounds of the imagery

  • Determine why this error occurs. Are we calculating bounding boxes correctly?
  • Implement better handling of this error in satellite_data.py/download_satellite_data

related to #22

@klwetstone klwetstone added package Related to phase 2 open-source package bug Something isn't working labels Aug 10, 2023
@ejm714
Copy link
Collaborator

ejm714 commented Aug 30, 2023

Worth a quick investigation (~1 hour) to see if there's anything more we can learn

@ejm714 ejm714 assigned klwetstone and unassigned klwetstone Aug 30, 2023
@ejm714
Copy link
Collaborator

ejm714 commented Sep 29, 2023

This appears to be caused by projection issues. To reproduce take a tif where the no data in bounds error occurs and reproject to the CRS of the lat lon point. Then, look at the xarray DataArray and you'll see that the lat/lons on the tif do not contain the lat/lon point. It's still unclear to me why the planetary computer registers the point as being in the bounding box.

@ejm714 ejm714 added enhancement New feature or request and removed package Related to phase 2 open-source package bug Something isn't working labels Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants