Can we update the CSV upload rules to account for the new subcategories

[drenfr01]

breaking this out to a new ticket from #472 . this is the CSV upload. @TylerSheffels, mind taking a stab at this since you built the CSV upload?

[ballek]

[ballek]

@drenfr01 @TylerSheffels bump

[TylerSheffels]

It's been a while since i have messed with the csv upload. Is this just asking for the csv upload to include a column for subcategory? Is there any logic that goes along with that like verifying that the subcategories are valid or can we assume you won't upload invalid ones? Is there anything else that the csv upload currently doesn't do that it should?

[ballek]

👋🏻 @TylerSheffels ... no need to include a new column for subcategory, just update what that the app will accept in the 'category' field. currently, if i try to submit anything but the following in that field
the app doesn't seem to like to recognize them. (Here are the new ones!

• Adult Education Class, Workshop
• Attending a Performance, Festival (4 hours max)
• Donating clothing, goods, foods (100 Points)
• Early Childhood Playgroup
• Exercise program, event
• Financial Advisor Meeting
• Financial, Employment Workshops
• Fitness Class
• Health Workshop
• In-school Meeting, Event
• In-school Volunteer, Chaperone
• Job Fairs
• Lending Circles, FII Meetings
• Political Activity: rally, advocacy, event
• Program at Library, Museum, Education Center
• Volunteer: Helping Others (non-family)
• Volunteer: Organization, Event
• Voter Engagement, Registration
• Workshop, Info Session, Meeting)

Aside from that, I could never seem to get the privateEvent/privateWhitelist feature to work. Helpful for uploading mass amount of private events to specific people!

[TylerSheffels]

@ballek I think this is actually working, although not how you think. During the upload process, we assign a SuperCategory based on the category field in the .csv. We look into the EventCategories collection, and match based on EventCategories.name = csvUpload.category. I am adding a quick error message that will tell you when it can't find the category, but can you try uploading based on a category name you know exists (you can probably look in Houston to make sure its correct).

[ballek]

@TylerSheffels
I'm a bit hesitant to mess with Houston since there are rules attached to each category... As long as I know what to update I'm happy to do so! Also, none of the community subcategories seem to be in there which messed up my CSV upload test

(Here is the spreadsheet I used, saved as xlsx to please the github gods)
testEvent.xlsx

[TylerSheffels]

I don't think I was clear in my last message. There shouldn't need to be any code changes to support new categories. If those categories exist in an EventCategory.name, we will set to the event. If it can't find the event category, we will mark that row as bad and say "Can't find category". Are you still seeing this error? What happens when you try to upload that test list?

[ballek]

@TylerSheffels I'm understanding this better, and for the categories that are on Houston, this seems to be working fine. My question: how would I go about adding these categories to Houston, what is the syntax I need to know regarding rules? Additionally, there are two collections titled "eventCategories", to which should I add?

[TylerSheffels]

@ballek Turns out I kind of lied here. We "reset" the event categories and set them to the list outlined here: https://github.com/drenfr01/unionCapital/blob/master/meteor/lib/collections/EventCategories.js#L38-L239

If that data structure makes sense to you, can you tell me if there is any differences from what you expect? (You should also be able to look at Houston on QA and tell me from that)

There should only be one eventCategories collection on QA now, if thats not the case let me know.

[ballek]

Hi @TylerSheffels! Thanks for investigating into this... A few changes to note:

Education looks pretty good,
but can we remove:
{
name: 'Chaperone Field Trip/Sport Activity',
rules: ['LESS_THAN_OR_EQUAL_2_HOURS'],
},

and add
{
name: 'Program at Library, Museum, Education Center'
rules: ['LESS_THAN_OR_EQUAL_2_HOURS'],
},

Health, Finance, Community look perfect.

And maybe it's a caching issue on my end, but I'm still seeing two dang EventCategories on Houston!

[TylerSheffels]

@drenfr01 I have updated the categories, but the two EventCategories collections sounds funky and my guess is that it has to do with the deploy process. Am I right to say that on next deploy you want to remove both of those categories?

[ballek]

update: prod only has one EventCategories collection!