-
Notifications
You must be signed in to change notification settings - Fork 1
/
Copy pathTODO
49 lines (46 loc) · 2.85 KB
/
TODO
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
[x] Account Management
[x] Add account
[x] Remove account
[x] Set current account
[x] Network Management
[x] Init networks to db from default list with YAK Router address
[x] Update network rpc (select network -> update rpc)
[x] set current network
[x] update network YAK Router address
[x] Query
[x] Query adapters
[x] Query price of a single adapter (using some test case from yak-aggregator)
[x] Query for best path of a router
[x] Native Token Handle
[x] Swap
[x] Check for balance before swap
[x] Check for approve before swap, suggest to approve more
[x] Wrap Native Token
[x] Unwrap Native Token
[x] Query & Swap (select tokens, amount, password on CURRENT_WALLET, check approve or use permit)
[x] swap from avax (native)
[x] swap to avax (native)
[x] Tokens
[x] Add custom tokens
[x] Support for multi chain
[] UX
[x] Return to terminal
[] not panic, but handle errors
[] Requested by @avocadozebra 14.01
[x] Path display
Might be worth considering if some users want to see adapters or token symbols path goes through. I kinda like the simple design, but just thinking this could also be helpful in some cases. Maybe like a setting user can set.
[x] It would be helpful if users can select/see their token balance for the amount in (eg. imagine you have balance of 1.023404 and u want to trade all)
[x] Display estimated gas-cost for swapping
[x] By the time swap lands on the chain the quote could already expire so it is useful if user could select with how much slippage they want to trade. Or to make it safer you could suggest some slippage already to which they just agree.
[x] With each extra step path is searched for the view-gas increases exponentially, some chains/nodes allow for higher some for lower view-gas so user should be able to configure with how many steps they want to search the path with
[] ! Better error handling if tx fails (eth_estimateGas fails - tx doesnt actually land)
[x] Better error handling if wallet password is incorrect
[] ? I noticed in some cases the query didnt return back the quote
[] ? I wasn’t able to add new network, update RPC or YakRouter + after playing with this the network wasn’t recognized anymore even if I selected back the default (I had to delete cli.db for it to work again)
[x] Just “good to have” but far far from neccesary: Suppose you get a quote between two assets, but becaouse there is only one market supported with very low liquidity u get a very bad price. It is hard to recognise if that price is a “bad” price or this is the actual rate. There was one case where a guy lost a bit of money on YakSwap beacouse of that. A way to resolve this would be to also show 1inch/coingecko price for comparison :)
[x] Settings tab
[x] Path Hops
[x] Slippage
[x] Compare with external quote (cowswap/1inch?)
[x] Remove custom token
[x] Permit support