Avoid zero-length array allocations and storing them in static fields (CA1825) #10267
+39
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
requested review from
dipeshmsft,
singhashish-wpf and
Kuldeep-MS
dotnet-policy-service
bot
added
PR
|
Could |
I'm not a fan. In cases like assigning to already defined field or parameter you lose the visible type information. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR mainly resolves
CA1825but in some cases goes a step further over standard analyzer fix.readonlyfields (whether they're marked or not), as the pointer to such array is already accessible viaArray.Empty<Type>().XamlTypeMapperwas going step further and cloning this zero-length array even. Happy days.RowSpanVectorwas performing unnecessary assigment if the branch was not taken.Customer Impact
Increased performance, decreased allocations.
Regression
No.
Testing
Local build.
Risk
Should be low.
Microsoft Reviewers: Open in CodeFlow