Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strips inline comments #862

Open
MilesCranmer opened this issue Aug 14, 2024 · 2 comments
Open

Strips inline comments #862

MilesCranmer opened this issue Aug 14, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@MilesCranmer
Copy link
Contributor

julia> using JuliaFormatter

julia> format_text("T <: Tuple #=e.g., Tuple{Union{Float32,Float64}}=# && !(T isa Union) #= e.g., Union{Tuple{A},Tuple{B}}=#")
"T <: Tuple && !(T isa Union) #= e.g., Union{Tuple{A},Tuple{B}}=#"

Seems to strip the first inline comment completely

@domluna
Copy link
Owner

domluna commented Aug 19, 2024

I think I can get this to work in the rewrite to JuliaSyntax

@domluna domluna added the bug Something isn't working label Aug 19, 2024
@domluna
Copy link
Owner

domluna commented Oct 6, 2024

fixed with JuliaSyntax, the comments will now be there although the whitespace might be different for the time being (0 vs 1 space or vice-versa), but that is something that can be improved later on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants