From f3b985155df04f600144ae53e18251ce46844cc2 Mon Sep 17 00:00:00 2001 From: Sean Whalen Date: Mon, 28 Oct 2024 20:35:21 -0400 Subject: [PATCH] Actual, actual 7.5.1 release --- checkdmarc/bimi.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/checkdmarc/bimi.py b/checkdmarc/bimi.py index f88b718..48155d0 100644 --- a/checkdmarc/bimi.py +++ b/checkdmarc/bimi.py @@ -533,7 +533,7 @@ def parse_bimi_record( pairs = BIMI_TAG_VALUE_REGEX.findall(record) tags = OrderedDict() - certificate_provided = False + hash_match = False for pair in pairs: tag = pair[0].lower().strip() @@ -565,7 +565,6 @@ def parse_bimi_record( response.raise_for_status() pem_bytes = response.content cert_metadata = get_certificate_metadata(pem_bytes, domain=domain) - hash_match = False if ( image_metadata["sha256_hash"] == cert_metadata["logodata_sha256_hash"] @@ -577,7 +576,7 @@ def parse_bimi_record( ) except Exception as e: warnings.append(f"Unable to download mark certificate - {str(e)}") - certificate_provided == hash_match and cert_metadata["valid"] + certificate_provided = hash_match and cert_metadata["valid"] if not certificate_provided: warnings.append( "Most providers will not display a BIMI image without a valid mark certificate"