-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BSOD with Dokan 0.7.3 RC on Windows 8.1 Pro x64 #27
Comments
Hello Can you give me some more informations ? |
Yes I still have mounted drive when I shutdown. |
In your dokan folder you should have a mirror.exe |
When I type this command Drive M is mounted |
What happen if you shutdown when it is mounted ? |
When I exit FISSH, mount the drive with mirror.exe and shutdown, there is BSOD |
Ok |
Please download the driver from this post BenjaminKim/dokanx#47 and test it. Should work also in your case. If it works fine I will make a pull request and dokany can merge it. |
Thank you @marinkobabic but I am not a big fan to installing something that I do not know 😢 |
Hello I have installed the driver (right click on the INF file and "Install") and there is still BSOD I forgot to mention it but I have a message when FiSSH start : |
@mapomme1108 The change I have made now is related to deletion of device object, when keep alive timeout is reached, is not used or if your application was not closed properly and somebody still tries to access the device. @Liryna |
I have tried the new version but the problem is the same. BSOD message is : "SYSTEM_SERVICE_EXECPTION = Dokanx.sys" I have installed WinSSHFS and it is working (I have used FiSSH so far) |
You can use the newest dokan library, but my driver. So I have to install https://github.com/tuiSSE/win-sshfs and then run the software. Close it and shutdown the machine to get the BSOD? |
Yes you can try but you have to install the Dokan Library 0.7.3 RC first EDIT : I don't close the software before to shutdown |
I'm not able to reproduce your issue with https://github.com/dimov-cz/win-sshfs/releases 1.5.12.5 and dokany version 0.7.1. So please provide me all links of the installers and the steps so that I can reproduce the problem. If I can reproduce it, I will fix the BSOD :-) |
So I was able to reproduce the BSOD using FISSH. Please download this driver and perform the test again and let me know if all works as expected. Let's see if you can break this version of the driver. What here the special case is, is that we have two dokan devices. That is the reason why it's so hard to reproduce this issue. |
FYI, with v0.7.3-RC just for a test. i mount folder with the delphi-mirror-sample and shutdown my pc (Win8.1 x64) windows crash (no BSOD). after restart i get a memory dump. i think, if i would manage WM_QUERYENDSESSION / WM_ENDSESSION, it should unmount correctly, i will check this tomorrow i don't know, whether there are other ways in the driver, to prevent this behavior |
You should never get a BSOD even if your application crashes. Did you try the driver above? |
@marinkobabic thank you for your implication, you're helping a lot on Dokan community but if only few people are testing your driver here I believe it is because you just posted binaries without any explanation of your changes. Proceeding like this is not community oriented, and more important it even violates Dokan sys project LGPL license (=> distributing a modified version of the project without the source code). This is definitely not the way it should be done. You should fork the repositories and create a different branch for each of your test. |
@marinkobabic i will test only drivers from this repo |
I got it to work this way : 1- install Dokan 0.6 (required by winsshfs) 4- Uninstall Dokan 0.6
|
? whats the diffent between 1- install Dokan 0.6 (required by winsshfs) and 3- install dokan x86 driver provided by marinkobacic isn't Dokan 0.6 a driver? |
1- Install Dokan 0.6 It works! |
@mapomme1108 @Maxhy |
@marinkobabic About your pull request, DokanY has sync the part of your pull request that keep the current logic. For us, we think your request is closed. If you want to have feedback and test in your new changes, I highly suggest you to provide a pull request to DokanY. |
@Liryna By the way my changes related to BSOD are now synced to my fork of dokanx. You can investigate the changes. Feel free to ask if something is not clear. I'm still working on a special BSOD which is hard to reproduce. This one was not reported by community. |
i think this one https://github.com/marinkobabic/dokanx/tree/Windows8DeleteIssue |
@marinkobabic Good news ! Thank you alot :) ! I will be glad to look at it in the next days 😃 |
Ok I took a look on your changes @marinkobabic. These look really good, you even removed few code duplication on irp completion and few bugs will be fixed indeed. |
|
2- Ok so if I understand well, DokanStopEventNotificationThread will not block but KeWaitForSingleObject in DokanStopEventNotificationThreadInternal will still hangs forever ? |
Correct. You can test it using FISSH. Simple way to reproduce is:
|
Ok I'm confident with your changes now, thank you for the publication and explanations. I ported your fixes to Dokany with commit 837633a |
@mapomme1108 could you try with https://github.com/dokan-dev/dokany/releases/tag/0.7.3-RC2? I wasn't able to reproduce your BSOD with previous version so if this is fixed with this pre-release which include @marinkobabic, please close this issue. |
Ok, I will try tomorrow |
I have tried FISSH package and Winsshfs with 0.7.3 RC2 but both dont work There are BSOD on unmount and shutdown with this error message : Maybe I can try on a clean Windows 8.1 install? |
Please try it on clean Windows 8.1 and let me know how I can reproduce it. |
I'm still having masive problems with BSOD during the development of my app. Whether I close my app or the debug stops it dont seam to matter. I have an onClose calleback on my c# app where I call dokan.revomeMountPoint('s:') dokan.unmount('s') before exiting but it dose no differens any tip on how do you handle the development cykle? Calling dokanclt.exe /u s return 0 and the app still crache the computer when closing it. |
Pleaso do the following:
Thanks |
Don't forget to rename the memory dump because the system overwrites it every time you get BSOD. Maybe we need one of them. |
According to my modest knowledge: Would it bring something to take a look at the stable system driver of TrueCrypt? |
It is right that TrueCrypt have a windows driver but dokan work differently :( |
I am experiencing the same issue with the C# mirror sample using 0.7.3 RC2 on Windows 8.1 pro x64. It does not matter how I exit the app, e.g just close it, or unmount the drive first it causes a BSOD with "PAGE_FAULT_IN_NONPAGE_AREA" Here's is the output of !analyze -v on my memory dump 5: kd> !analyze -v
PAGE_FAULT_IN_NONPAGED_AREA (50) Debugging Details:***** Kernel symbols are WRONG. Please fix symbols to do analysis. ADDITIONAL_DEBUG_TEXT: MODULE_NAME: dokan FAULTING_MODULE: fffff8030f215000 nt DEBUG_FLR_IMAGE_TIMESTAMP: 55a020f0 WRITE_ADDRESS: ffffffffffffffd0 FAULTING_IP: MM_INTERNAL_CODE: 0 DEFAULT_BUCKET_ID: WIN8_DRIVER_FAULT BUGCHECK_STR: AV CURRENT_IRQL: 0 ANALYSIS_VERSION: 6.3.9600.17336 (debuggers(dbg).150226-1500) amd64fre LAST_CONTROL_TRANSFER: from fffff8030f39505e to fffff8030f365ca0 STACK_TEXT: STACK_COMMAND: kb FOLLOWUP_IP: SYMBOL_STACK_INDEX: 5 SYMBOL_NAME: dokan+5af7 FOLLOWUP_NAME: MachineOwner IMAGE_NAME: dokan.sys BUCKET_ID: WRONG_SYMBOLS FAILURE_BUCKET_ID: WRONG_SYMBOLS ANALYSIS_SOURCE: KM FAILURE_ID_HASH_STRING: km:wrong_symbols FAILURE_ID_HASH: {70b057e8-2462-896f-28e7-ac72d4d365f8} Followup: MachineOwner |
Thanks for the analyze @jbrads. Is that a complete/kernel memory dump or a small memory dump (minidump)? If minidump, could you share your dump file for analyze on my side too? Otherwise here is the pdb file for Dokan 0.7.3 RC2 Windows 8.1 x64 driver file: http://wikisend.com/download/541738/dokan.pdb (I tried to use SymbolSource.org to automate symbols publication but it is a bit complicated if you're not using NuGet...). My source files are stored on F:\dev\dokan\dokany. |
Your dump would be very interesting if you could provide it. Is it always the same stack trace? Please send us the link to the dump. |
Hi, apologies for the delay. It is a complete memory dump at 2.4GB. Here is the updated output with the symbols loaded, I'll repro the issue and crash my PC now and see if it changes ;) ADDITIONAL_DEBUG_TEXT: MODULE_NAME: dokan FAULTING_MODULE: fffff8030f215000 nt DEBUG_FLR_IMAGE_TIMESTAMP: 55a020f0 WRITE_ADDRESS: ffffffffffffffd0 FAULTING_IP: MM_INTERNAL_CODE: 0 DEFAULT_BUCKET_ID: WIN8_DRIVER_FAULT BUGCHECK_STR: AV CURRENT_IRQL: 0 ANALYSIS_VERSION: 6.3.9600.17336 (debuggers(dbg).150226-1500) amd64fre LAST_CONTROL_TRANSFER: from fffff8030f39505e to fffff8030f365ca0 STACK_TEXT: STACK_COMMAND: kb FOLLOWUP_IP: FAULTING_SOURCE_LINE: f:\dev\dokan\dokany\sys\timeout.c FAULTING_SOURCE_FILE: f:\dev\dokan\dokany\sys\timeout.c FAULTING_SOURCE_LINE_NUMBER: 372 SYMBOL_STACK_INDEX: 5 SYMBOL_NAME: dokan!DokanStopCheckThread+73 FOLLOWUP_NAME: MachineOwner IMAGE_NAME: dokan.sys BUCKET_ID: WRONG_SYMBOLS FAILURE_BUCKET_ID: WRONG_SYMBOLS ANALYSIS_SOURCE: KM FAILURE_ID_HASH_STRING: km:wrong_symbols FAILURE_ID_HASH: {70b057e8-2462-896f-28e7-ac72d4d365f8} Followup: MachineOwner |
Hi, I can confirm in my case it is the same stack trace and location each time |
It's a merge issue. Can be fixed very easy. DokanStopCheckThread shoul remove the following lines
Those lines are part of DokanStopCheckThreadInternal. |
@marinkobabic Well find 😄 ! |
Thanks, if you update this issue when the RC is available I will verify. |
Thanks for the analyze @jbrads, the issue identification @marinkobabic and the fix @Liryna. I just published signed drivers @jbrads if you want to test again with latest changes: https://github.com/dokan-dev/dokany/releases/tag/0.7.3-RC3 |
Thanks, I can confirm I can no longer reproduce this issue with RC3 |
I can confirm that it also solved the problem for me as well! I tried breaking out of the application over and over again without a hitch. great work! 👍 |
Works here as well, on win10
|
Hello,
I use Dokan 0.7.3 RC (latest) for FISSH on Windows 8.1 Pro x64.
I have BSOD everytime I shutdown the computer.
If I uninstall Dokan, the BSOD dissapears.
Is there à fix for this?
Thanks.
The text was updated successfully, but these errors were encountered: