-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BackgroundIframeJs violating CSP #192
Comments
A cleaner workaround is probably to just disable the background iframe altogether, i.e. something like:
... although looking at the code, it currently only creates the background iframe for IE and the old (pre-chromium) version of edge. Were you testing on IE? The iframe might still be needed there, not sure. |
@wkeese I wasn't testing on IE, for some reason it got triggered in Chrome, I'm not 100% sure why something like this would have happened. It's a legacy application so there might have been some work done to make it so that it gets called always to keep behaviour consistent across all browsers? |
Sounds pretty complicated. I agree of course that you shouldn't modify dojo's source if you can help it. To be clear, I was talking about setting Like you said, maybe your app/company set the BackgroundIframe to show up for all browsers, via I double-checked the BackgroundIframe.js in https://github.com/dojo/dijit/releases/tag/1.10.4, i.e. https://github.com/dojo/dijit/blob/03e1c2418c1eae2aa96bb536cc778499827e07aa/BackgroundIframe.js, and (AFAICT) it only enables the iframe for IE and MSEdge. |
I am attempting to implement a CSP, using self, some domains, some hashes as well as a nonce.
My CSP is flagging script-src-elem when attempting to run line 75 of BackgroundIframe.js. I believe that it is because the iframe src property is being set to javascript:"".
Removing the explicit setting of the src to javascript:'' solves the issue.
The text was updated successfully, but these errors were encountered: