Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog._dialogStack holds reference to removed node #189

Open
xmedeko opened this issue Mar 15, 2021 · 0 comments
Open

Dialog._dialogStack holds reference to removed node #189

xmedeko opened this issue Mar 15, 2021 · 0 comments

Comments

@xmedeko
Copy link
Contributor

xmedeko commented Mar 15, 2021

Dialog._dialogStack items focus property is not cleared, so the 0th item may hold a reference to an item removed from DOM i.e. kind of a leak. I suggest one of the following solutions:

  • Stop using previous ds item and just set previous focus to the current ds item.
  • The focus in the previous ds item is removed on hide().
  • The focus is held by a weak reference.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant