Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for exceeding memory limit #39

Open
pdawyndt opened this issue Aug 1, 2019 · 1 comment
Open

add support for exceeding memory limit #39

pdawyndt opened this issue Aug 1, 2019 · 1 comment
Labels
enhancement New feature or request migrated

Comments

@pdawyndt
Copy link
Contributor

pdawyndt commented Aug 1, 2019

For now, the docker kills the judge when it exceeds the set memory limit. This should be handled by the judge itself (if possible). Oddly enough, the judge reports the error as a Timeout, whereas it should be an indication that the docker was killed because the memory limit has been exceeded.

Example: submission 817578

@ninewise Can you check why Dodona does not report this error as a memory limit issue. Clearly, when I run the script, it is killed before the time limit is exceeded.

Original issue by @pdawyndt on Sun Apr 30 2017 at 18:31.

@ninewise
Copy link

ninewise commented Aug 1, 2019

When the last script in the docker exits with status code 143 (which is will when it's killed by the docker), this is reported as a timeout. I can fix this (change it to an internal error, which is more accurate).

However, I can't make the distinction between this memory-error and, say, another exit 143 (like the one from an actual timeout). I left it as is, because the pythia judge has quite some submissions hitting this memory-killing/timeout backup catch.

Original comment by @ninewise on Mon May 01 2017 at 16:20.

@dodona-server dodona-server added enhancement New feature or request migrated labels Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request migrated
Projects
None yet
Development

No branches or pull requests

3 participants