Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is contributions accepted for this repo? #2

Open
jinnabaalu opened this issue Apr 19, 2023 · 3 comments
Open

Is contributions accepted for this repo? #2

jinnabaalu opened this issue Apr 19, 2023 · 3 comments

Comments

@jinnabaalu
Copy link

If the contribution is accepted, can we add a CONTRIBUTION.md file?
I have a plan to add docker-compose to the repo and extend the README file

@nunocoracao
Copy link
Collaborator

Hello @JinnaBalu, thanks for reaching out. Yes, we are planning to accept contributions for this repo and are working on creating the files you mentioned. Just to clarify, this repo is used as part of the new walkthrough experience within Docker Desktop so it has some tie-ins to that experience. We will update the readme file to provide better context to the repo.
We'll follow up on this issue once we're ready to take contributions. Again, thanks for your questions and help.

@jinnabaalu
Copy link
Author

I have a minimal set of docker-compose files in different areas, which are not covered here. Can I start creating the PR for the compose files I am working on?

What are the acceptance criteria?

@nunocoracao
Copy link
Collaborator

Hello again @JinnaBalu I would ask you to wait until we update the readme files with the context for this repo. Again, this is a project meant to be used as a walkthrough experience within Docker Desktop so I am not sure the files you are planning to submit would fit the goals here.

veres845 added a commit to veres845/welcome-to-docker that referenced this issue Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants