From e561dc7473612b136f43629eb1c70dab6618c70e Mon Sep 17 00:00:00 2001
From: Thomas Bernard <thomashbernard@gmail.com>
Date: Fri, 31 May 2024 20:04:51 +0200
Subject: [PATCH] Standardize securing footer

---
 frontend/src/components/ResultPage.vue        | 12 +++++-----
 .../utils/firearms-utils/epaule-a-verrou.ts   | 22 ++++++++-----------
 .../pistolet-semi-auto-moderne.ts             | 22 ++++++++-----------
 frontend/src/utils/firearms-utils/revolver.ts | 22 ++++++++-----------
 .../semi-auto-style-militaire-autre.ts        | 22 ++++++++-----------
 .../GuideIdentificationFirearm.vue            |  6 ++---
 .../IdentificationSelectAmmo.vue              |  4 ++--
 7 files changed, 47 insertions(+), 63 deletions(-)

diff --git a/frontend/src/components/ResultPage.vue b/frontend/src/components/ResultPage.vue
index 62b08fb7..1340bc3b 100644
--- a/frontend/src/components/ResultPage.vue
+++ b/frontend/src/components/ResultPage.vue
@@ -20,7 +20,7 @@ const img = computed(() => resultStore.img)
 const typology = TYPOLOGIES[resultStore.typology]
 
 const isDummy = computed(() => stepsStore.isDummy)
-const hasGuideDummy = typology?.guideDummy !== undefined
+const hasDummyOptions = typology?.dummyOptions !== undefined
 const isCardDetected = computed(() => resultStore.gunLength !== null && resultStore.gunBarrelLength !== null)
 
 const isUp = ref(false)
@@ -75,7 +75,7 @@ function sendFeedback (isCorrect: boolean) {
   <div class="result-frame -mx-8 py-5 px-8">
     <div class="result">
       <h2
-        v-if="$route.name === 'IdentificationTypologyResult' && hasGuideDummy"
+        v-if="$route.name === 'IdentificationTypologyResult' && hasDummyOptions"
         class="typology-title bg-white py-4"
       >
         Typologie de l'arme
@@ -144,7 +144,7 @@ function sendFeedback (isCorrect: boolean) {
               >
                 {{ label }}
               </h3>
-              <template v-if="confidenceLevel !== 'low' && ($route.name !== 'IdentificationTypologyResult' || !hasGuideDummy)">
+              <template v-if="confidenceLevel !== 'low' && ($route.name !== 'IdentificationTypologyResult' || !hasDummyOptions)">
                 <h3
                   class="fr-alert__title"
                   data-testid="arm-category"
@@ -157,14 +157,14 @@ function sendFeedback (isCorrect: boolean) {
               </template>
             </div>
             <div
-              v-if="disclaimer && confidenceLevel !== 'low' && ($route.name !== 'IdentificationTypologyResult' || !hasGuideDummy)"
+              v-if="disclaimer && confidenceLevel !== 'low' && ($route.name !== 'IdentificationTypologyResult' || !hasDummyOptions)"
               class="fr-alert fr-alert--warning"
             >
               <p v-html="disclaimer" />
             </div>
             <MissingCardAlert v-if="MEASURED_GUNS_TYPOLOGIES.includes(typology) && isCardDetected === false && isDummy == false" />
             <div
-              v-if="confidenceLevel !== 'low' && ($route.name !== 'IdentificationTypologyResult' || !hasGuideDummy)"
+              v-if="confidenceLevel !== 'low' && ($route.name !== 'IdentificationTypologyResult' || !hasDummyOptions)"
               class="fr-callout mt-3"
             >
               <p class="fr-callout__text">
@@ -178,7 +178,7 @@ function sendFeedback (isCorrect: boolean) {
               </p>
             </div>
             <div
-              v-if="confidenceLevel !== 'low' && $route.name === 'IdentificationTypologyResult' && hasGuideDummy"
+              v-if="confidenceLevel !== 'low' && $route.name === 'IdentificationTypologyResult' && hasDummyOptions"
               class="fr-alert fr-alert--warning"
             >
               <p>
diff --git a/frontend/src/utils/firearms-utils/epaule-a-verrou.ts b/frontend/src/utils/firearms-utils/epaule-a-verrou.ts
index e8223b31..56f4bd2d 100644
--- a/frontend/src/utils/firearms-utils/epaule-a-verrou.ts
+++ b/frontend/src/utils/firearms-utils/epaule-a-verrou.ts
@@ -28,20 +28,16 @@ export const epaule_a_verrou = {
       ],
     },
   ],
-  guideDummy: [
+  dummyOptions: [
     {
-      options: [
-        {
-          label: 'Balles',
-          value: 'cartouches',
-          img_ammo: epauleAVerrouCartridges,
-        },
-        {
-          label: 'Billes ou trou pour billes',
-          value: 'billes',
-          img_ammo: epauleAVerrouBalls,
-        },
-      ],
+      label: 'Balles',
+      value: 'cartouches',
+      img_ammo: epauleAVerrouCartridges,
+    },
+    {
+      label: 'Billes ou trou pour billes',
+      value: 'billes',
+      img_ammo: epauleAVerrouBalls,
     },
   ],
   getDisclaimer: getEpaulLevierVerrouDisclaimer,
diff --git a/frontend/src/utils/firearms-utils/pistolet-semi-auto-moderne.ts b/frontend/src/utils/firearms-utils/pistolet-semi-auto-moderne.ts
index a61de593..6c52be97 100644
--- a/frontend/src/utils/firearms-utils/pistolet-semi-auto-moderne.ts
+++ b/frontend/src/utils/firearms-utils/pistolet-semi-auto-moderne.ts
@@ -50,20 +50,16 @@ export const pistolet_semi_auto_moderne = {
       ],
     },
   ],
-  guideDummy: [
+  dummyOptions: [
     {
-      options: [
-        {
-          label: 'Cartouches',
-          value: 'cartouches',
-          img_ammo: pistoletSemiAutoModerneCartridges,
-        },
-        {
-          label: 'Billes',
-          value: 'billes',
-          img_ammo: pistoletSemiAutoModerneBalls,
-        },
-      ],
+      label: 'Cartouches',
+      value: 'cartouches',
+      img_ammo: pistoletSemiAutoModerneCartridges,
+    },
+    {
+      label: 'Billes',
+      value: 'billes',
+      img_ammo: pistoletSemiAutoModerneBalls,
     },
   ],
   getDisclaimer: (category: string) => {
diff --git a/frontend/src/utils/firearms-utils/revolver.ts b/frontend/src/utils/firearms-utils/revolver.ts
index c567528b..b0da961e 100644
--- a/frontend/src/utils/firearms-utils/revolver.ts
+++ b/frontend/src/utils/firearms-utils/revolver.ts
@@ -163,20 +163,16 @@ export const revolver = {
       ],
     },
   ],
-  guideDummy: [
+  dummyOptions: [
     {
-      options: [
-        {
-          label: 'Balles',
-          value: 'cartouches',
-          img_ammo: revolverCartridges,
-        },
-        {
-          label: 'Billes ou trou pour billes',
-          value: 'billes',
-          img_ammo: revolverBalls,
-        },
-      ],
+      label: 'Balles',
+      value: 'cartouches',
+      img_ammo: revolverCartridges,
+    },
+    {
+      label: 'Billes ou trou pour billes',
+      value: 'billes',
+      img_ammo: revolverBalls,
     },
   ],
   getDisclaimer: (category: string) => {
diff --git a/frontend/src/utils/firearms-utils/semi-auto-style-militaire-autre.ts b/frontend/src/utils/firearms-utils/semi-auto-style-militaire-autre.ts
index 324d0837..744cc2e6 100644
--- a/frontend/src/utils/firearms-utils/semi-auto-style-militaire-autre.ts
+++ b/frontend/src/utils/firearms-utils/semi-auto-style-militaire-autre.ts
@@ -101,20 +101,16 @@ export const semi_auto_style_militaire_autre = {
       ],
     },
   ],
-  guideDummy: [
+  dummyOptions: [
     {
-      options: [
-        {
-          label: 'Cartouches',
-          value: 'cartouches',
-          img_ammo: semiAutoMilitaireCartridges,
-        },
-        {
-          label: 'Billes',
-          value: 'billes',
-          img_ammo: semiAutoMilitaireBalls,
-        },
-      ],
+      label: 'Cartouches',
+      value: 'cartouches',
+      img_ammo: semiAutoMilitaireCartridges,
+    },
+    {
+      label: 'Billes',
+      value: 'billes',
+      img_ammo: semiAutoMilitaireBalls,
     },
   ],
   getDisclaimer: () => "<strong>Catégorie A</strong> si à l'origine l’arme était à <strong>répétition automatique</strong> puis a été <strong>transformée</strong> en arme <strong>semi automatique</strong>, ou si l’arme possède <strong>une crosse rétractable / pliable</strong> et qu’en configuration la plus courte elle <strong>mesure moins de 60 cm</strong>.",
diff --git a/frontend/src/views/GuideIdentificationFirearm/GuideIdentificationFirearm.vue b/frontend/src/views/GuideIdentificationFirearm/GuideIdentificationFirearm.vue
index c0a398c5..6284d077 100644
--- a/frontend/src/views/GuideIdentificationFirearm/GuideIdentificationFirearm.vue
+++ b/frontend/src/views/GuideIdentificationFirearm/GuideIdentificationFirearm.vue
@@ -23,7 +23,7 @@ const currentStep = ref(1)
 const isLowConfidence = confidenceLevel.value === 'low'
 
 const steps = computed(() => {
-  if (TYPOLOGIES[typology]?.guideDummy || !isLowConfidence) {
+  if (TYPOLOGIES[typology]?.dummyOptions || !isLowConfidence) {
     if (ALARM_GUNS_TYPOLOGIES.includes(resultStore.typology) && stepsStore.selectedAmmo === 'cartouches') {
       return ['Typologie de l\'arme', 'Compléments', 'Typologie de munitions', 'Identification d\'une arme d\'alarme', 'Résultat final']
     } else {
@@ -97,7 +97,7 @@ const showDiv = ref(false)
   <div class="mt-5 fr-container">
     <div class="result fr-col-11 fr-col-lg-6 mx-auto">
       <StepsGuide
-        v-if="TYPOLOGIES[typology]?.guideDummy"
+        v-if="TYPOLOGIES[typology]?.dummyOptions"
         class="!fr-container my-auto"
         :steps="steps"
         :current-step="currentStep"
@@ -106,7 +106,7 @@ const showDiv = ref(false)
     </div>
   </div>
   <div
-    v-if="$route.path === '/guide-identification/resultat-final' || TYPOLOGIES[typology]?.guideDummy == undefined"
+    v-if="$route.path === '/guide-identification/resultat-final' || TYPOLOGIES[typology]?.dummyOptions == undefined"
     class="footer end z-1"
   >
     <div class="fr-col-11 fr-col-lg-6 mx-auto">
diff --git a/frontend/src/views/GuideIdentificationFirearm/IdentificationSelectAmmo.vue b/frontend/src/views/GuideIdentificationFirearm/IdentificationSelectAmmo.vue
index 6624de1a..3bcf0e72 100644
--- a/frontend/src/views/GuideIdentificationFirearm/IdentificationSelectAmmo.vue
+++ b/frontend/src/views/GuideIdentificationFirearm/IdentificationSelectAmmo.vue
@@ -52,7 +52,7 @@ onMounted(() => {
 })
 
 // eslint-disable-next-line camelcase
-type HasGuideDummy = typeof epaule_a_verrou | typeof pistolet_semi_auto_moderne | typeof semi_auto_style_militaire_autre | typeof revolver
+type HasDummyOptions = typeof epaule_a_verrou | typeof pistolet_semi_auto_moderne | typeof semi_auto_style_militaire_autre | typeof revolver
 </script>
 
 <template>
@@ -123,7 +123,7 @@ type HasGuideDummy = typeof epaule_a_verrou | typeof pistolet_semi_auto_moderne
     </div>
     <div>
       <template
-        v-for="(option) in (TYPOLOGIES[typology] as HasGuideDummy)?.guideDummy[0].options"
+        v-for="(option) in (TYPOLOGIES[typology] as HasDummyOptions)?.dummyOptions"
         :key="option.value"
       >
         <div class="item">