Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

Implementation of Incremental Decoding #1582

Open
barry-jin opened this issue Nov 30, 2021 · 0 comments · May be fixed by #1583
Open

Implementation of Incremental Decoding #1582

barry-jin opened this issue Nov 30, 2021 · 0 comments · May be fixed by #1583
Labels
bug Something isn't working

Comments

@barry-jin
Copy link
Contributor

Description

The implementation of incremental decoding in gluon-nlp is somewhat different from fairseq. In fairseq, the keys/values both before and after linear projection are memorialized, but in gluon-nlp, only the keys/values before the linear projection is memorialized. This difference leads to different execution number of FC operators (In fairseq, keys/values are directly pulled from prev_keys/prev_values; In gluon-nlp, two more linear projections are needed to get the projectioned keys/values). We may need to correct the gluon-nlp's implementation of incremental decoding.

@barry-jin barry-jin added the bug Something isn't working label Nov 30, 2021
@barry-jin barry-jin linked a pull request Mar 15, 2022 that will close this issue
6 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant