Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BratReader does not support N1 Reference tags #1391

Open
alaindesilets opened this issue Jul 6, 2019 · 5 comments
Open

BratReader does not support N1 Reference tags #1391

alaindesilets opened this issue Jul 6, 2019 · 5 comments
Assignees
Labels

Comments

@alaindesilets
Copy link
Contributor

alaindesilets commented Jul 6, 2019

If you run ReadBrat.java in the attached Maven project, you get this errror:

Exception in thread "main" java.lang.IllegalStateException: Unknown annotation format: [N1	Reference T1 Wikipedia:Q95	Google]

Yet, the annotation in question is perfectly valid, according to the brat format specification:

https://brat.nlplab.org/standoff.html

I should point out that we are encountering this problem because we are using BratReader to read some files that were previously annotated by MetamapLite, and that tool makes use of the Reference line in the .ann files.

@reckart
Copy link
Member

reckart commented Jul 7, 2019

So far, normalizations (N) are not supported by the BratReader/BratWriter in DKPro Core.

@alaindesilets
Copy link
Contributor Author

alaindesilets commented Jul 7, 2019 via email

@alaindesilets
Copy link
Contributor Author

alaindesilets commented Jul 7, 2019 via email

@reckart
Copy link
Member

reckart commented Jul 8, 2019

The contribution guidelines include links to coding convention templates.

Yes, there are unit tests for the brat module.

If I understand it correctly, then the normalization annotations in brat are essentially like attributes. The BratReader could probably just treat them as String attributes. The BratWriter would need some way of configuring which attributes should be rendered as normalization attributes instead of regular attributes.

@alaindesilets
Copy link
Contributor Author

alaindesilets commented Jul 8, 2019 via email

@reckart reckart added Module-io.brat ⭐️ Enhancement New feature or request labels Jul 18, 2019
@reckart reckart added this to the 1.12.0 milestone Jul 18, 2019
@reckart reckart modified the milestones: 1.12.0, Backlog Sep 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants