Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port over gll-combinators test suite #11

Open
djspiewak opened this issue Jan 13, 2017 · 3 comments
Open

Port over gll-combinators test suite #11

djspiewak opened this issue Jan 13, 2017 · 3 comments
Labels
low hanging

Comments

@djspiewak
Copy link
Owner

Most of the gll-combinators test suite is highly applicable to parseback, and the syntax is very very close. It should be relatively easy to port over most of the tests. As an initial spike, any test which is failing should just be marked as pendingUntilFixed.

The gll-combinators test suite is here.
@ChristopherDavenport
Copy link
Contributor

Are you opposed to depending on scalacheck and specs2-scalacheck as in the gll-combinators library? Would make implementation simpler.

@djspiewak
Copy link
Owner Author

Not at all opposed! Very much in favor, in fact.

Merged
@djspiewak
Copy link
Owner Author

Started the process of moving things over. Found a bunch of bugs in the process. Still resolving, but work is in master now.

djspiewak added a commit that referenced this issue Feb 11, 2017
@djspiewak
Added a neat test from gll
1b517a6 
Affects #11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
low hanging
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@djspiewak @ChristopherDavenport