Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aldryn-search dependency aldryn-common isn't compatible with newer django version #105

Open
bhuiyanmobasshir94 opened this issue Jan 19, 2021 · 2 comments

Comments

@bhuiyanmobasshir94
Copy link

bhuiyanmobasshir94 commented Jan 19, 2021

Django newer versions don't support QuerySetPaginator and I am getting errors while reindexing. I am explicitly getting this error.
ImportError: cannot import name 'QuerySetPaginator' from 'django.core.paginator'
When I commented out the above-mentioned class QuerySetPaginator from site-packages it works properly.

N.B: Aldryn-common is archived by authors, but why this popular library isn't updating their dependency.

@filipweidemann
Copy link

Bumping it. Currently running into the same issue as well.

Is there any effort by the maintainers? We can obviously help out, but considering this packages last commit is from 21st February 2020 I assume this is dead..?

@filipweidemann
Copy link

It is actually quite simple to fix this. aldryn_common is only used for its DiggPaginator, so technically we could open a PR with removed dependency and added DiggPaginator to aldryn_search's own codebase.

Gonna think about it..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants