Skip to content
This repository has been archived by the owner on Nov 23, 2024. It is now read-only.

Check the hash of (downloaded) ninja binary before executing #173

Open
jmackie opened this issue Jan 16, 2023 · 0 comments
Open

Check the hash of (downloaded) ninja binary before executing #173

jmackie opened this issue Jan 16, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@jmackie
Copy link
Member

jmackie commented Jan 16, 2023

If we're going to download and execute ninja, we should really check its integrity.

pub async fn run(matches: &ArgMatches) -> Result<()> {
let exe = get_ninja_exe().await?;
let args = matches.get_many::<String>("ninja_args").unwrap();
let status = process::Command::new(exe)
.args(args)
.status()
.into_diagnostic()?;
process::exit(status.code().unwrap_or(0));
}

@jmackie jmackie added the enhancement New feature or request label Jan 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

1 participant