Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alias 'RowDVectorView<>' is missing for the result of DMatrix<T>.row() #1411

Open
kasparthommen opened this issue Jun 20, 2024 · 1 comment

Comments

@kasparthommen
Copy link

kasparthommen commented Jun 20, 2024

Consider this:

let my_dmatrix: DMatrix<f64> = ...;
let x: DVectorView<f64> = my_dmatrix.column(0);  // there is the DVectorView alias, happy days
let x: RowDVectorView<f64> = my_dmatrix.row(0);  // but RowDVectorView doesn't exist
//     ^^^^^^^^^^^^^^

Seems like a type called RowDVectorView might be missing for consistency?

pub type RowDVectorView<'a, T, RStride = U1, CStride = Dyn> = Matrix<T, U1, Dyn, ViewStorage<'a, T, U1, Dyn, RStride, CStride>>;
@Andlon
Copy link
Collaborator

Andlon commented Jun 21, 2024

Yes, you're right. This is implemented in #1232, but currently helped up by some unresolved questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants