Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine if updated can ever be false when a registration record is found (but not changed) #113

Open
dlongley opened this issue Feb 27, 2024 · 0 comments

Comments

@dlongley
Copy link
Member

See: https://github.com/digitalbazaar/bedrock-tokenization/blob/v21.1.0/lib/documents.js#L320

From testing, it appears that updated will always be set to true whether or not the record in the database changed based on lastErrorObject.n being set to 1 (this is how updated is implemented internally). If updated is always true, we can simplify at least the comment exposition that follows after the above link in the function (and remove the FIXME) -- it may not change the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant