Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AG/KHUR for "agriculture" appears in Typey Type #339

Closed
paulfioravanti opened this issue Apr 14, 2020 · 7 comments
Closed

AG/KHUR for "agriculture" appears in Typey Type #339

paulfioravanti opened this issue Apr 14, 2020 · 7 comments

Comments

@paulfioravanti
Copy link
Contributor

While practicing on Typey Type, AG/KHUR came up for "agriculture". Looking up Plover for a possibly better outline, I found AG/KULT, which gels with me better. I was going to submit a PR that changes the Gutenberg dictionary to use AG/KULT (and hence have that used in Typey Type), but it would seem that it's already being used:

I thought that Typey Type in general sources from the Gutenberg dictionary, but in this case, is it sourcing this outline from the shortest outline with the highest alphabetical order in dict.json?

@paulfioravanti
Copy link
Contributor Author

I've just seen the same issue with "KORT/KWROUS": "courteous" appearing with Typey Type, yet the Gutenberg entry has a "more correct" outline of:

(I was considering sending a PR to change this to KURT/KWRUS, but I see it's already considered a mis-stroke)

"KURT/KWRUS": "courteous",

@paulfioravanti
Copy link
Contributor Author

Same issue also with seeing "SKWRUPBG/*L": "jungle" in Typey Type, yet Gutenberg also has what I consider to be a better entry of:

@didoesdigital
Copy link
Owner

Hmm, are you using the experimental setting to show steno hints on the fly? Does changing that setting give you the expected strokes? didoesdigital/typey-type#6 (comment)

@paulfioravanti
Copy link
Contributor Author

I do have that setting, so I've now cleared it out for now. If the issue ends up persisting, I'll follow up in the Typey Type repo, since this problem is not related specifically to the dictionaries. Thanks, @didoesdigital!

@didoesdigital
Copy link
Owner

@paulfioravanti I've found something in the (not open-source) static lesson generator project that builds the Typey Type dictionary that I need to change, so don't worry about filing the issue on the Typey Type repo. I'll go ahead and get that sorted. It's surfaced some other tweaks to make in the dictionaries so I'll push those out together soon.

Thanks for flagging these.

@didoesdigital
Copy link
Owner

@paulfioravanti I ended up changing courteous to "KORT/KWRO*US": "courteous" to use the suffix "KWRO*US": "{^eous}", and to be consistent with "KORT": "court" and not "KURT": "curt",

@didoesdigital
Copy link
Owner

@paulfioravanti latest changes should properly show Gutenberg entries.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants