Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Report]: DynamicGroup 被复制后，内部的节点归属异常 #1956

Open
ZivvW opened this issue Nov 9, 2024 · 0 comments · May be fixed by #1960
Open

[Bug Report]: DynamicGroup 被复制后，内部的节点归属异常 #1956

ZivvW opened this issue Nov 9, 2024 · 0 comments · May be fixed by #1960
Labels
bug Something isn't working

Comments

@ZivvW
Copy link

ZivvW commented Nov 9, 2024

发生了什么？

DynamicGroup 被复制后，它的 children 会跑到新复制出的分组中，此时拖动复制出的分组，原分组的children会跟着移动。
查看节点 data 可以发现，原分组的 children 会同时属于两个 DynamicGroup

复现方式：在官网的动态分组demo 上按如下操作：

  1. 将 circle 拖入 dynamic-group
  2. 复制 dynamic-group
  3. 拖动 dynamic-group

gif:
chrome-capture-2024-11-9

logicflow/core版本

2.0.7

logicflow/extension版本

2.0.11

logicflow/engine版本

No response

浏览器&环境

No response
@ZivvW ZivvW added the bug Something isn't working label Nov 9, 2024
ZivvW pushed a commit to ZivvW/LogicFlow that referenced this issue Nov 11, 2024
fix(extension): 【dynamic-group】DynamicGroup 被复制后，内部的节点归属异常
6345a8d 
DynamicGroup 重写的 addElements 用原分组节点创建新的时，移除的 children 取值有问题，children 应该在 properties 中

Closes didi#1956
@ZivvW ZivvW mentioned this issue Nov 11, 2024
Closed
ZivvW pushed a commit to ZivvW/LogicFlow that referenced this issue Nov 12, 2024
fix(extension): 【dynamic-group】DynamicGroup 被复制后，内部的节点归属异常
53b8aa2 
DynamicGroup 重写的 addElements 用原分组节点创建新的时，移除的 children 取值有问题，children 应该在 properties 中

Closes didi#1956
@ZivvW ZivvW linked a pull request Nov 12, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@ZivvW