Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: mathjs version produces build warning #295

Open
kamejosh opened this issue May 18, 2024 · 2 comments
Open

[Bug]: mathjs version produces build warning #295

kamejosh opened this issue May 18, 2024 · 2 comments
Assignees
Labels

Comments

@kamejosh
Copy link

Description

rpg-dice-roller v5.5.0 uses an old version of mathjs which in combination with produces the following errors when building with vite:

node_modules/mathjs/lib/esm/entry/configReadonly.js (6:20): A comment

"/* #__PURE__ */"

in "node_modules/mathjs/lib/esm/entry/configReadonly.js" contains an annotation that Rollup cannot interpret due to the position of the comment. The comment will be removed to avoid issues.
node_modules/mathjs/lib/esm/type/unit/physicalConstants.js (47:0): A comment

"// export const createSpectralRadiance = /* #__PURE__ */ unitFactory('spectralRadiance', '1.1910429723971881e-16', 'W m^2 sr^-1') // TODO spectralRadiance"

in "node_modules/mathjs/lib/esm/type/unit/physicalConstants.js" contains an annotation that Rollup cannot interpret due to the position of the comment. The comment will be removed to avoid issues.
node_modules/mathjs/lib/esm/utils/number.js (24:18): A comment

"/* #__PURE__ */"

in "node_modules/mathjs/lib/esm/utils/number.js" contains an annotation that Rollup cannot interpret due to the position of the comment. The comment will be removed to avoid issues.
node_modules/mathjs/lib/esm/utils/number.js (39:18): A comment

"/* #__PURE__ */"

in "node_modules/mathjs/lib/esm/utils/number.js" contains an annotation that Rollup cannot interpret due to the position of the comment. The comment will be removed to avoid issues.
node_modules/mathjs/lib/esm/utils/number.js (48:19): A comment

"/* #__PURE__ */"

in "node_modules/mathjs/lib/esm/utils/number.js" contains an annotation that Rollup cannot interpret due to the position of the comment. The comment will be removed to avoid issues.
node_modules/mathjs/lib/esm/utils/number.js (57:19): A comment

"/* #__PURE__ */"

in "node_modules/mathjs/lib/esm/utils/number.js" contains an annotation that Rollup cannot interpret due to the position of the comment. The comment will be removed to avoid issues.
node_modules/mathjs/lib/esm/utils/number.js (70:18): A comment

"/* #__PURE__ */"

in "node_modules/mathjs/lib/esm/utils/number.js" contains an annotation that Rollup cannot interpret due to the position of the comment. The comment will be removed to avoid issues.
node_modules/mathjs/lib/esm/utils/number.js (94:19): A comment

"/* #__PURE__ */"

in "node_modules/mathjs/lib/esm/utils/number.js" contains an annotation that Rollup cannot interpret due to the position of the comment. The comment will be removed to avoid issues.

This error should be fixed in mathjs Version v12.3.1:
josdejong/mathjs#3114 (comment)

Dice Roller version

v5.5.0

Bundle type

ESM

Node version

v20.12.2

Browser name and version

@kamejosh
Copy link
Author

Is there an update for it, would you allow a PR if I'd provide it?

@GreenImp
Copy link
Collaborator

Sorry, I've not had the chance to have a look yet.
PRs are always welcome though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants