Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Authentication #13

Open
areller opened this issue Feb 18, 2022 · 3 comments
Open

Support Authentication #13

areller opened this issue Feb 18, 2022 · 3 comments

Comments

@areller
Copy link

areller commented Feb 18, 2022

I have this situation where I have blockchain-node behind a proxy that imposes basic auth.

Are there plans to make this library support passing an authz header?

Something like this maybe

struct ClientOptions {
    base_url: String,
    timeout: Option<u64>,
    authorization: Option<String>,
}

....

impl Client {
....

    pub fn new(opts: ClientOptions) -> Self { ... }
}

would you accept a PR for this?

@lthiery
Copy link
Collaborator

lthiery commented Mar 9, 2022

I would encourage a PR, but I'm not a maintainer. Happy to be added as maintainer to this crate since I use it quite a bit @olb1ue

@olb1ue
Copy link
Contributor

olb1ue commented Mar 9, 2022

sure, just added you

@lthiery
Copy link
Collaborator

lthiery commented Mar 31, 2022

@areller if you still have interest in doing this, I'd be happy to review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants