Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Filter Relative Lifetime after reset #4

Open
thypon opened this issue Sep 25, 2021 · 1 comment
Open

Incorrect Filter Relative Lifetime after reset #4

thypon opened this issue Sep 25, 2021 · 1 comment

Comments

@thypon
Copy link
Contributor

thypon commented Sep 25, 2021

When hit by /priv-api/reset the filter lifetime in seconds is copy pasted to the filter relative time.
Here a log about the incident:

Before Reset

Sep 25 08:07:23 192.168.1.66 persistence: Commit persistence storage
Sep 25 08:07:27 192.168.1.66 persistence: Stats:
Sep 25 08:07:27 192.168.1.66 persistence:  - Lifetime: 124929 seconds
Sep 25 08:07:27 192.168.1.66 persistence:  - Filter installated at 0 seconds
Sep 25 08:07:27 192.168.1.66 persistence:  - Filter relative lifetime: 100649 (NOT seconds)
Sep 25 08:07:27 192.168.1.66 persistence:  - Last dust at 0 rel lifetime
Sep 25 08:07:27 192.168.1.66 persistence: Settings:
Sep 25 08:07:28 192.168.1.66 persistence:  - Power: on
Sep 25 08:07:28 192.168.1.66 persistence:  - Lights: on
Sep 25 08:07:28 192.168.1.66 persistence:  - Lock: off
Sep 25 08:07:28 192.168.1.66 persistence:  - Speed: 1
Sep 25 08:07:28 192.168.1.66 persistence:  - Prev speed: 3
Sep 25 08:07:28 192.168.1.66 persistence:  - Timer left: 0 minutes
Sep 25 08:07:28 192.168.1.66 persistence:  - User maintenance reminder: False
Sep 25 08:07:28 192.168.1.66 persistence: Commit persistence storage

After Reset

Sep 25 08:07:40 192.168.1.66 persistence: Stats:
Sep 25 08:07:40 192.168.1.66 persistence:  - Lifetime: 124932 seconds
Sep 25 08:07:40 192.168.1.66 persistence:  - Filter installated at 0 seconds
Sep 25 08:07:40 192.168.1.66 persistence:  - Filter relative lifetime: 124926 (NOT seconds)
Sep 25 08:07:40 192.168.1.66 persistence:  - Last dust at 0 rel lifetime
Sep 25 08:07:40 192.168.1.66 persistence: Settings:
Sep 25 08:07:40 192.168.1.66 persistence:  - Power: on
Sep 25 08:07:40 192.168.1.66 persistence:  - Lights: on
Sep 25 08:07:40 192.168.1.66 persistence:  - Lock: off
Sep 25 08:07:40 192.168.1.66 persistence:  - Speed: 1
Sep 25 08:07:40 192.168.1.66 persistence:  - Prev speed: 3
Sep 25 08:07:40 192.168.1.66 persistence:  - Timer left: 0 minutes
Sep 25 08:07:40 192.168.1.66 persistence:  - User maintenance reminder: False
Sep 25 08:07:41 192.168.1.66 persistence: Commit persistence storage
Sep 25 08:08:23 192.168.1.66 persistence: Persistence._persist_lifetime()
@depau
Copy link
Owner

depau commented Sep 25, 2021

Mmh, reset just hard resets the board. It may be worth adding a hook to do proper handling of persistent data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants