Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Simplify Barrage Viewport Table Updates #362

Open
deephaven-internal opened this issue Nov 18, 2024 · 0 comments
Open

feat: Simplify Barrage Viewport Table Updates #362

deephaven-internal opened this issue Nov 18, 2024 · 0 comments

Comments

@deephaven-internal
Copy link

This issue was auto-generated

PR: deephaven/deephaven-core#6347
Author: nbauernfeind

Original PR Body

Fixes #6039.
Fixes #6053.

The barrage viewport protocol has now changed:

  • viewports are never sent included rows; all added rows are included
  • added rows are position space from within the server-respected client requested viewport
  • removed rows are position space from within the server-respected client requested viewport
  • snapshots on viewports include removed rows to simplify client side processing
  • barrage update metadata now explicitly includes current table size; viewports no longer track the source table's full rowset

viewport clients must infer shifts:

  • removed rows are in pre-update space
  • added rows are in post-update space
  • the end-result viewport is retained rows + added rows (retained are the existing rows minus removed rows) where the adds are in the offsets specified by added rows

In this PR we'll bump the following dependencies:

  • flatbuffer from 1.12.0 to 24.3.25
  • arrow from 13.0.0 to 18.0.0
  • protobuf 3.25.3 to 3.25.4
  • barrage from 0.6.0 to 0.7.2 (noting that 0.7.x was released for this feature set)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant