Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deps] Update development related dependencies #3357

Merged
merged 19 commits into from
Apr 6, 2021

Conversation

matheusd
Copy link
Member

@matheusd matheusd commented Apr 1, 2021

Rebased on top of #3346

This updates most packages to use their latest version. The only packages not updated are related to major UI elements (react, i18n), which might need more extensive code changes, so those are left for a future PR.

Notable changes:

  • Removed our custom node-addon-loader in favor of the webpack standard node-loader
  • Uncoupled the electron webpack config from the base webpack config (the electron config overrides most options anyway)
  • Updated the electron webpack config so that yarn build && yarn start correctly work under windows
  • Changed from using fbjs-scripts checkEngine to use the standard package.json engines entry, updated to minimum required versions of node and yarn
  • Ran yarn-deduplicate to remove duplicate entries in yarn.lock
  • Removed deps from package.json that were either not used anymore or are implicitly required by other deps
  • Allowed all chrome-extension:// requests in development mode to fix extension-related warnings
  • Regenerated protobuf files (due to dependency upgrades)
  • Upgraded winston to latest major version (finally gets rid of the related dev startup warning)

@matheusd matheusd changed the title Update stuff [deps] Update development related dependencies Apr 1, 2021
@matheusd matheusd marked this pull request as ready for review April 6, 2021 18:43
@alexlyp
Copy link
Member

alexlyp commented Apr 6, 2021

yarn dev seems to work fine, but seeing Unchecked runtime.lastError: "sync" is not available in this instance of Chrome in the console logs.

Actually seeing this on master as well, so must be something else causing it.

@alexlyp
Copy link
Member

alexlyp commented Apr 6, 2021

Tested and works on all 3 dev, build && start and pacakge.

@alexlyp alexlyp merged commit 283d438 into decred:master Apr 6, 2021
@matheusd matheusd deleted the update-stuff branch April 7, 2021 11:18
@matheusd
Copy link
Member Author

matheusd commented Apr 7, 2021

yarn dev seems to work fine, but seeing Unchecked runtime.lastError: "sync" is not available in this instance of Chrome in the console logs.

That error is due to redux-devtools being broken for newer electron versions: zalmoxisus/redux-devtools-extension#767

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants