Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pension Means of Living 0.1 improvements #4

Open
phax opened this issue May 31, 2022 · 0 comments
Open

Pension Means of Living 0.1 improvements #4

phax opened this issue May 31, 2022 · 0 comments

Comments

@phax
Copy link
Member

phax commented May 31, 2022

Hi guys,
while scanning through pensionMeansOfLivingEvidence-0.1.xsd I found some issues with the MonetaryAmountType.

  • Please change the upper bound of the cardinality of "Currency" to 1. One monetary value can only have one Currency at a time.
  • I suggest you change the data type of the Amount element from a custom xs:integer to xs:decimal to also allow fraction digits
  • I suggest you change the limitations of the data type of the Amount element to not use a regular expression, but instead use xs:minInclusive and xs:maxInclusive instead. That should increase performance and is easier to read.

// Philip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant