Fix when placing flextable footnote to multiple columns and rows #2063
+58
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ddsjoberg added a test, let me know if it was what you were looking for. Only place where I cannot add a footnote is the stubhead so far |
Melkiades
approved these changes
Nov 12, 2024
|
Thanks @Melkiades ! Can you take a look into the failing CI/CD? |
ddsjoberg
commented
Nov 15, 2024
…b.com:ddsjoberg/gtsummary into 2062-flextable-multi-row-col-footnote
ddsjoberg
commented
Nov 19, 2024
R/as_flex_table.R
Outdated
| \(location_ids, tab_location, row_numbers) { | ||
| col_ids <- getElement(location_ids, "column_id") |> unique() | ||
| if (tab_location == "body") col_ids <- rep(col_ids, length(row_numbers)) # styler: off | ||
| sort(col_ids) |
There was a problem hiding this comment.
Hi @Melkiades , I was doing some final checks, and saw that we were not placing the footnote correctly. I added the sort() to get it right which changed the footnote placement from this
to
Is there a way to test that the placement of the footnote markers is where we expect in a flextable?
Thanks!
Melkiades
reviewed
Nov 19, 2024
| @@ -303,22 +303,22 @@ test_that("as_flex_table passes multiple table footnotes correctly", { | |||
| modify_table_styling( | |||
| columns = stat_1, | |||
| rows = (variable %in% "grade") & (row_type == "level"), | |||
| footnote = "Cell-level foonotes here." | |||
| footnote = "my footnote" | |||
There was a problem hiding this comment.
the bug appeared when we were assigning the same footnote to multiple locations. separate footnotes were assigned with separate calls to the flextable footnote function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
If there is an GitHub issue associated with this pull request, please provide link.
closes #2062
@Melkiades before fully reviewing this PR, can you add a test or two more for different types of footnote placement to ensure they are correctly placed when there is one column and multiple rows, multiple columns and one row, and one mixed-type when the column/rows are contiguous? Thank you!
Reviewer Checklist (if item does not apply, mark is as complete)
pkgdown::build_site(). Check the R console for errors, and review the rendered website.devtools::test_coverage()usethis::use_spell_check()runs with no spelling errors in documentationWhen the branch is ready to be merged into master:
NEWS.mdwith the changes from this pull request under the heading "# gtsummary (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (seeNEWS.mdfor examples).usethis::use_version(which = "dev")usethis::use_spell_check()again