Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

links don't match app route helpers #86

Open
ghost opened this issue Aug 29, 2017 · 0 comments
Open

links don't match app route helpers #86

ghost opened this issue Aug 29, 2017 · 0 comments

Comments

@ghost
Copy link

ghost commented Aug 29, 2017

my app's page params are in the url

things_path(page: 2) # => "/things/page/2"

not

things_path(page: 2) # => "/things?page=2"

however, the generated links use this second form, which appears to be hardcoded in Pagination#_paginate_collection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
0 participants