Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhandled TypeError exception on cache dir creation failure #67

Open
jcmcken opened this issue Mar 23, 2016 · 2 comments
Open

Unhandled TypeError exception on cache dir creation failure #67

jcmcken opened this issue Mar 23, 2016 · 2 comments

Comments

@jcmcken
Copy link
Contributor

jcmcken commented Mar 23, 2016

This line leads to an unhandled TypeError in this line (TypeError: 'NoneType' object is unsubscriptable).

Perhaps it should log an error instead, and continue to return the data (so the remote defs would be loaded every time, and not cached locally, but at least the client operation would potentially still succeed)?

jcmcken added a commit to jcmcken/python-foreman that referenced this issue Mar 23, 2016
@david-caro
Copy link
Owner

I think that the return you point out should return data instead of null yes

jcmcken added a commit to jcmcken/python-foreman that referenced this issue Mar 23, 2016
jcmcken added a commit to jcmcken/python-foreman that referenced this issue Mar 23, 2016
@jcmcken
Copy link
Contributor Author

jcmcken commented Mar 23, 2016

Sorry about the spam, clearly haven't had enough caffeine today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants