Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug allowing lmer to work in tax_model #52

Closed
wants to merge 1 commit into from

Conversation

david-barnett
Copy link
Owner

No description provided.

@david-barnett david-barnett linked an issue Jun 6, 2022 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Merging #52 (aadb2a6) into main (07f1fdb) will increase coverage by 8.12%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
+ Coverage   61.90%   70.02%   +8.12%     
==========================================
  Files          66       66              
  Lines        4407     4407              
==========================================
+ Hits         2728     3086     +358     
+ Misses       1679     1321     -358     
Impacted Files Coverage Δ
R/tax_model.R 69.64% <100.00%> (ø)
R/ord_plot.R 82.80% <0.00%> (+0.63%) ⬆️
R/comp_barplot.R 93.70% <0.00%> (+2.79%) ⬆️
R/ps_extra-accessors.R 57.69% <0.00%> (+7.69%) ⬆️
R/ord_explore.R 82.54% <0.00%> (+33.90%) ⬆️
R/tax_fix_interactive.R 100.00% <0.00%> (+53.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07f1fdb...aadb2a6. Read the comment docs.

@david-barnett david-barnett deleted the tax-model-lmer-fix branch May 9, 2023 13:37
@SilasK
Copy link

SilasK commented Jun 28, 2023

Hello, I would also be interested in this feature. Is it abandoned?

@SilasK
Copy link

SilasK commented Jun 28, 2023

It seems one can now specify lmer as type?

@david-barnett
Copy link
Owner Author

yep the bug that prevented lmer use is fixed in main branch a while ago, but I still have not tested whether outputting lmerMod models would play nice with other microViz tax* functions.

I suspect some weird behaviour will arise somewhere if you try, but a quick google suggests broom.mixed package might provide a sane way forward. i.e loading broom.mixed should allow tax_models2stats to work with lmer output...

anyway, if you try it, I'm happy to hear about your experiences and issues, and such feedback would make proper integration of mixed effects model support in microViz more likely 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mixed models using taxatree_models()
3 participants