From 3ca1619271831da746c61a09e41aaa42de8ab674 Mon Sep 17 00:00:00 2001
From: David Barnett <david.barnett@maastrichtuniversity.nl>
Date: Wed, 3 Jan 2024 11:54:04 +0100
Subject: [PATCH] stop testing old ggplot 3.3.6 compatibility

---
 .github/workflows/R-CMD-check-ggplot336.yaml | 38 --------------------
 tests/testthat/test-ord_explore-shinytest2.R |  4 ---
 2 files changed, 42 deletions(-)
 delete mode 100644 .github/workflows/R-CMD-check-ggplot336.yaml

diff --git a/.github/workflows/R-CMD-check-ggplot336.yaml b/.github/workflows/R-CMD-check-ggplot336.yaml
deleted file mode 100644
index 8f4063ab..00000000
--- a/.github/workflows/R-CMD-check-ggplot336.yaml
+++ /dev/null
@@ -1,38 +0,0 @@
-# Workflow derived from https://github.com/r-lib/actions/tree/v2/examples
-# Need help debugging build failures? Start at https://github.com/r-lib/actions#where-to-find-help
-on:
-  push:
-    branches: [main]
-  pull_request:
-    branches: [main]
-
-name: R-CMD-check-ggplot336
-
-jobs:
-  R-CMD-check:
-    runs-on: ubuntu-latest
-    env:
-      GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}
-      R_KEEP_PKG_SOURCE: yes
-
-    steps:
-      - uses: actions/checkout@v3
-
-      - uses: r-lib/actions/setup-r@v2
-        with:
-          use-public-rspm: true
-
-      - uses: r-lib/actions/setup-r-dependencies@v2
-        with:
-          extra-packages: any::rcmdcheck
-          needs: check
-
-      - name: "Install ggplot2 version 3.3.6"
-        run: remotes::install_version("ggplot2", version = "3.3.6", upgrade = FALSE)
-        shell: Rscript {0}
-
-      - name: "Install ggiraph version 0.8.3"
-        run: remotes::install_version("ggiraph", version = "0.8.3", upgrade = FALSE)
-        shell: Rscript {0}
-
-      - uses: r-lib/actions/check-r-package@v2
diff --git a/tests/testthat/test-ord_explore-shinytest2.R b/tests/testthat/test-ord_explore-shinytest2.R
index b5af68c8..064c9c0d 100644
--- a/tests/testthat/test-ord_explore-shinytest2.R
+++ b/tests/testthat/test-ord_explore-shinytest2.R
@@ -49,10 +49,6 @@ test_that("ord_explore app works: unconstrained ords", {
   app$wait_for_idle()
   app$expect_values() # 2
 
-  # Skip test based on package versions
-  skip_if_not(packageVersion("ggiraph") > "0.8.3" || packageVersion("ggplot2") < "3.4.0")
-  # test locally with dev version in the meantime until visual change in barplot legend (thick borders) is fixed
-
   # check state after first build
   app$click("build")
   app$wait_for_idle()